In latest xen-unstable, result of xentrace_format is wrong, because the data format of hvmtrace is changed. Signed-off-by: Disheng Su <disheng.su@intel.com> _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Should tools/xentrace/formats be installed by the Makefile with "make
install"?
If so, to what directory? And what filename? ("formats" is a bit too
generic)
I propose "/etc/xen/xentrace_format.defs" Anybody disagree?
(And wherever it goes, the location should be mentioned in the man page.)
> -----Original Message-----
> From: xen-devel-bounces@lists.xensource.com
> [mailto:xen-devel-bounces@lists.xensource.com]On Behalf Of Su, Disheng
> Sent: Friday, December 28, 2007 12:45 AM
> To: xen-devel@lists.xensource.com
> Subject: [Xen-devel] [PATCH] xentrace bug fix
>
>
> In latest xen-unstable, result of xentrace_format is wrong,
> because the
> data format of hvmtrace is changed.
>
> Signed-off-by: Disheng Su <disheng.su@intel.com>
>
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
> Should tools/xentrace/formats be installed by the Makefile with "make > install"? > > If so, to what directory? And what filename? ("formats" is a bit too > generic) > > I propose "/etc/xen/xentrace_format.defs" Anybody disagree?I think that''d be sensible; and make xentrace_format look there by default. Cheers, Mark> (And wherever it goes, the location should be mentioned in the man page.) > > > -----Original Message----- > > From: xen-devel-bounces@lists.xensource.com > > [mailto:xen-devel-bounces@lists.xensource.com]On Behalf Of Su, Disheng > > Sent: Friday, December 28, 2007 12:45 AM > > To: xen-devel@lists.xensource.com > > Subject: [Xen-devel] [PATCH] xentrace bug fix > > > > > > In latest xen-unstable, result of xentrace_format is wrong, > > because the > > data format of hvmtrace is changed. > > > > Signed-off-by: Disheng Su <disheng.su@intel.com> > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-devel-- Dave: Just a question. What use is a unicyle with no seat? And no pedals! Mark: To answer a question with a question: What use is a skateboard? Dave: Skateboards have wheels. Mark: My wheel has a wheel! _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On Fri, Jan 04, 2008 at 05:45:06PM +0000, Mark Williamson wrote:> > Should tools/xentrace/formats be installed by the Makefile with "make > > install"? > > > > If so, to what directory? And what filename? ("formats" is a bit too > > generic) > > > > I propose "/etc/xen/xentrace_format.defs" Anybody disagree? > > I think that''d be sensible; and make xentrace_format look there by default.Is the file editable by normal users? I would have thought not? regards john _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On Saturday 05 January 2008, John Levon wrote:> On Fri, Jan 04, 2008 at 05:45:06PM +0000, Mark Williamson wrote: > > > Should tools/xentrace/formats be installed by the Makefile with "make > > > install"? > > > > > > If so, to what directory? And what filename? ("formats" is a bit too > > > generic) > > > > > > I propose "/etc/xen/xentrace_format.defs" Anybody disagree? > > > > I think that''d be sensible; and make xentrace_format look there by > > default. > > Is the file editable by normal users? I would have thought not? >Right now, AFAIK it''s not actually installed since it''s a developer tool and it''s assumed you have a copy of the repository hanging around somewhere to get the format definitions from... Having a default path in /etc/xen/xentrace_format.defs would enable xentrace_format to translate xentrace output "out of the box". If that route were taken, then xentrace_format should still be able to take a format file as an argument to override the default. Does that sound OK? Cheers, Mark -- Dave: Just a question. What use is a unicyle with no seat? And no pedals! Mark: To answer a question with a question: What use is a skateboard? Dave: Skateboards have wheels. Mark: My wheel has a wheel! _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
John Levon wrote:> On Fri, Jan 04, 2008 at 05:45:06PM +0000, Mark Williamson wrote: > > >>> Should tools/xentrace/formats be installed by the Makefile with "make >>> install"? >>> >>> If so, to what directory? And what filename? ("formats" is a bit too >>> generic) >>> >>> I propose "/etc/xen/xentrace_format.defs" Anybody disagree? >>> >> I think that''d be sensible; and make xentrace_format look there by default. >> > > Is the file editable by normal users? I would have thought not? >Probably if a user has permission to run xentrace then he will also be able to edit the formats. Rob _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel