Yosuke Iwamatsu
2007-Dec-17 09:28 UTC
[Xen-devel] [PATCH] Xend: Fix Device Duplicate Check
Hi,
This patch fixes device duplicate check as follows.
- Add duplicate check for the blktap device
- Do case-insensitve comparison for mac addresses
Regards,
-------------------
Yosuke Iwamatsu
NEC Corporation
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
Masaki Kanno
2007-Dec-18 01:21 UTC
Re: [Xen-devel] [PATCH] Xend: Fix Device Duplicate Check
Hi Iwamatsu,
Could you improve your patch to cause an error in the following
conditions?
- different blktap disk type:
disk = [ ''tap:aio:/xen/root.img,hda1,w'',
''tap:sync:/xen/root.img,hdb1,w'' ]
^^^ ^^^^
- different device type:
disk = [ ''file:/xen/root.img,hda1,w'',
''tap:***:/xen/root.img,hdb1,w'' ]
^^^^ ^^^
Best regards,
Kan
Mon, 17 Dec 2007 18:28:05 +0900, Yosuke Iwamatsu wrote:
>Hi,
>
>This patch fixes device duplicate check as follows.
>
>- Add duplicate check for the blktap device
>- Do case-insensitve comparison for mac addresses
>
>Regards,
>-------------------
>Yosuke Iwamatsu
> NEC Corporation
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
Yosuke Iwamatsu
2007-Dec-18 06:47 UTC
Re: [Xen-devel] [PATCH] Xend: Fix Device Duplicate Check
Hi, Masaki Kanno wrote:> Hi Iwamatsu, > > Could you improve your patch to cause an error in the following > conditions? > > - different blktap disk type: > disk = [ ''tap:aio:/xen/root.img,hda1,w'', ''tap:sync:/xen/root.img,hdb1,w'' ] > ^^^ ^^^^ > - different device type: > disk = [ ''file:/xen/root.img,hda1,w'', ''tap:***:/xen/root.img,hdb1,w'' ] > ^^^^ ^^^Please take a look at the attach patch, which uses filename rather than uname for duplicate check of block devices. Thank you for the suggestion. Yosuke> > Best regards, > Kan > > Mon, 17 Dec 2007 18:28:05 +0900, Yosuke Iwamatsu wrote: > >> Hi, >> >> This patch fixes device duplicate check as follows. >> >> - Add duplicate check for the blktap device >> - Do case-insensitve comparison for mac addresses >> >> Regards, >> ------------------- >> Yosuke Iwamatsu >> NEC Corporation_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel