Xen devel - Dec 2007 - Re: [Xen-changelog] [xen-unstable] vt-d: Test device assignability in xend, but defer actual assignment to qemu-dm.

On Wed, Dec 12, 2007 at 01:50:23PM -0800, Xen patchbot-unstable wrote:
> +    case XEN_DOMCTL_test_assign_device:
> +    {
> +        u8 bus, devfn;
> +
Can we please get documentation of this in:

http://wiki.xensource.com/xenwiki/APIChangelog

thanks
john

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

On Wed, Dec 12, 2007 at 09:53:00PM +0000, John Levon wrote:
> On Wed, Dec 12, 2007 at 01:50:23PM -0800, Xen patchbot-unstable wrote:
> 
> > +    case XEN_DOMCTL_test_assign_device:
> > +    {
> > +        u8 bus, devfn;
> > +
> 
> Can we please get documentation of this in:
> 
> http://wiki.xensource.com/xenwiki/APIChangelog
Ping, please respond.

regards
john

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Hi John,

Good suggestion. I will add it to the wiki. 

Randy (Weidong)

John Levon wrote:
> On Wed, Dec 12, 2007 at 09:53:00PM +0000, John Levon wrote:
> 
>> On Wed, Dec 12, 2007 at 01:50:23PM -0800, Xen patchbot-unstable
>> wrote: 
>> 
>>> +    case XEN_DOMCTL_test_assign_device:
>>> +    {
>>> +        u8 bus, devfn;
>>> +
>> 
>> Can we please get documentation of this in:
>> 
>> http://wiki.xensource.com/xenwiki/APIChangelog
> 
> Ping, please respond.
> 
> regards
> john

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

On Wed, Dec 12, 2007 at 09:53:00PM +0000, John Levon wrote:
> On Wed, Dec 12, 2007 at 01:50:23PM -0800, Xen patchbot-unstable wrote:
> 
> > +    case XEN_DOMCTL_test_assign_device:
> > +    {
> > +        u8 bus, devfn;
> > +
> 
> Can we please get documentation of this in:
> 
> http://wiki.xensource.com/xenwiki/APIChangelog
This still isn''t added ... Keir, should I bother? I don''t
think people
will do anything unless you start enforcing it yourself :(

regards
john

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Done!

Randy (Weidong)

John Levon wrote:
> On Wed, Dec 12, 2007 at 09:53:00PM +0000, John Levon wrote:
> 
>> On Wed, Dec 12, 2007 at 01:50:23PM -0800, Xen patchbot-unstable
>> wrote: 
>> 
>>> +    case XEN_DOMCTL_test_assign_device:
>>> +    {
>>> +        u8 bus, devfn;
>>> +
>> 
>> Can we please get documentation of this in:
>> 
>> http://wiki.xensource.com/xenwiki/APIChangelog
> 
> This still isn''t added ... Keir, should I bother? I don''t
think people
> will do anything unless you start enforcing it yourself :(
> 
> regards
> john
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

John Levon writes ("Re: [Xen-devel] Re: [Xen-changelog] [xen-unstable]
vt-d: Test device assignability in xend, but defer actual assignment to
qemu-dm."):
> This still isn''t added ... Keir, should I bother? I don''t
think people
> will do anything unless you start enforcing it yourself :(
Perhaps it would be better to move the changelog to a file in the
source tree.  If we put our foot down just a little bit we could
reject (or fix up) patches that change the API but don''t document it
properly.

Currently much of the documentation in the tree is out of date or
wrong but I''m hoping we can gradually improve this.  Where there is
good documentation, I think patches ought not to go in if they make
the docs wrong.

IME you can do one of (a) accept that a piece of documentation will
rot, (b) try to find someone to chase up afterwards, or (c) insist
that the doc changes have to accompany (or precede) the code changes.
At the moment we have (a), and there is unfortunately little chance of
(b).  I think a sprinkling of (c) would help :-).

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

On 21/12/07 10:52, "Ian Jackson" <Ian.Jackson@eu.citrix.com>
wrote:
> IME you can do one of (a) accept that a piece of documentation will
> rot, (b) try to find someone to chase up afterwards, or (c) insist
> that the doc changes have to accompany (or precede) the code changes.
> At the moment we have (a), and there is unfortunately little chance of
> (b).  I think a sprinkling of (c) would help :-).
It requires a bit of a change of habit for me, and when I have a queue of
patches to review and apply it is easy to forget. If others comment on
patches on the list then that is a useful reminder, and I do take notice
when patch mails start a discussion.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

On Fri, Dec 21, 2007 at 10:52:27AM +0000, Ian Jackson wrote:
> > This still isn''t added ... Keir, should I bother? I
don''t think people
> > will do anything unless you start enforcing it yourself :(
> 
> Perhaps it would be better to move the changelog to a file in the
> source tree.
If that''s more useful I can do that, though I think it makes things a
bit harder: I have to fiddle with my patch instead of just editing a
wiki.

Keir I will try to spend time looking at patches on the list instead
of after the fact to try and get people to do this. It''s less
convenient
for me since I have to open up attachments, etc, but if we can get
people into the habit...

cheers,
john

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel