Stefan Berger
2007-Dec-03 12:14 UTC
[Xen-devel] [PATCH] [Xend/Xm/ACM] [1/2] Implement legacy XML-RPC interface for ACM commands
This patch implements a (non Xen-API) legacy XML-RPC interface for the ACM commands and funnels the calls into code introduced by the Xen-API support for ACM security management. Since some of the functionality has changed, also the xm applications have changed. In particular the following old commands have been removed along with some tools the have become obsolete now: - loadpolicy (included in: setpolicy) - makepolicy (included in: setpolicy) - cfgbootpolicy (included in: setpolicy) and the following commands been introduced: - setpolicy - getpolicy - resetpolicy All tools have been adapted to work in Xen-API and legacy XML-RPC mode. Both modes support the same functionality. An update to the documentation will follow as well as new test cases. I have run this and the 2nd patch with the xm-test suite on the tip of the staging tree and they caused no regressions. Signed-off-by: Stefan Berger <stefanb@us.ibm.com> _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Keir Fraser
2007-Dec-04 11:33 UTC
[Xen-devel] Re: [PATCH] [Xend/Xm/ACM] [1/2] Implement legacy XML-RPC interface for ACM commands
Both these patches are reported as corrupt by ''patch''. This one on line 1159 of the patch; the other one on line 99. In both cases the immediately preceding chunk fails to apply. -- Keir On 3/12/07 12:14, "Stefan Berger" <stefanb@us.ibm.com> wrote:> This patch implements a (non Xen-API) legacy XML-RPC interface for the > ACM commands and funnels the calls into code introduced by the Xen-API > support for ACM security management. Since some of the functionality has > changed, also the xm applications have changed. In particular the > following old commands have been removed along with some tools the have > become obsolete now: > > - loadpolicy (included in: setpolicy) > - makepolicy (included in: setpolicy) > - cfgbootpolicy (included in: setpolicy) > > and the following commands been introduced: > > - setpolicy > - getpolicy > - resetpolicy > > All tools have been adapted to work in Xen-API and legacy XML-RPC mode. > Both modes support the same functionality. > > An update to the documentation will follow as well as new test cases. > > I have run this and the 2nd patch with the xm-test suite on the tip of > the staging tree and they caused no regressions. > > Signed-off-by: Stefan Berger <stefanb@us.ibm.com> >_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Stefan Berger
2007-Dec-04 12:39 UTC
Re: [Xen-devel] Re: [PATCH] [Xend/Xm/ACM] [1/2] Implement legacy XML-RPC interface for ACM commands
xen-devel-bounces@lists.xensource.com wrote on 12/04/2007 06:33:42 AM:> Both these patches are reported as corrupt by ''patch''. This one on line1159> of the patch; the other one on line 99. In both cases the immediately > preceding chunk fails to apply.I just took the ones I posted with the mail program and they worked find. Also the ones I received back from the email list are ok. If it''s just two hunks that are corrupted, can you delete those hunks and commit it and I''ll diff the trees and resend the missing parts? Stefan> > -- Keir > > On 3/12/07 12:14, "Stefan Berger" <stefanb@us.ibm.com> wrote: > > > This patch implements a (non Xen-API) legacy XML-RPC interface for the > > ACM commands and funnels the calls into code introduced by the Xen-API > > support for ACM security management. Since some of the functionalityhas> > changed, also the xm applications have changed. In particular the > > following old commands have been removed along with some tools thehave> > become obsolete now: > > > > - loadpolicy (included in: setpolicy) > > - makepolicy (included in: setpolicy) > > - cfgbootpolicy (included in: setpolicy) > > > > and the following commands been introduced: > > > > - setpolicy > > - getpolicy > > - resetpolicy > > > > All tools have been adapted to work in Xen-API and legacy XML-RPCmode.> > Both modes support the same functionality. > > > > An update to the documentation will follow as well as new test cases. > > > > I have run this and the 2nd patch with the xm-test suite on the tip of > > the staging tree and they caused no regressions. > > > > Signed-off-by: Stefan Berger <stefanb@us.ibm.com> > > > > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-devel_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Keir Fraser
2007-Dec-04 23:15 UTC
Re: [Xen-devel] Re: [PATCH] [Xend/Xm/ACM] [1/2] Implement legacy XML-RPC interface for ACM commands
On 4/12/07 12:39, "Stefan Berger" <stefanb@us.ibm.com> wrote:> xen-devel-bounces@lists.xensource.com wrote on 12/04/2007 06:33:42 AM: > >> > Both these patches are reported as corrupt by ''patch''. This one on line >> 1159 >> > of the patch; the other one on line 99. In both cases the immediately >> > preceding chunk fails to apply. > > I just took the ones I posted with the mail program and they worked find. Also > the ones I received back from the email list are ok. > If it''s just two hunks that are corrupted, can you delete those hunks and > commit it and I''ll diff the trees and resend the missing parts?The errors I get are below, and occur with patch version 2.5.4 and 2.5.9. I suppose it could conceivably be metamail screwing up the patches when I extract them from the raw emails. Perhaps try resending the pair of patches in a zip file? -- Keir viper:xen64.hg$ patch -p2 <../tmp/security_commands_through_xend.diff patching file tools/python/xen/xend/server/XMLRPCServer.py patching file tools/python/xen/xm/addlabel.py patching file tools/python/xen/xm/rmlabel.py patching file tools/python/xen/util/xsm/acm/acm.py patching file tools/python/xen/xm/resources.py patching file tools/python/xen/xm/getlabel.py patching file tools/python/xen/xm/labels.py patching file tools/python/xen/xm/main.py Hunk #4 FAILED at 2459. 1 out of 4 hunks FAILED -- saving rejects to file tools/python/xen/xm/main.py.rej missing header for unified diff at line 1159 of patch can''t find file to patch at input line 1159 Perhaps you used the wrong -p or --strip option? The text leading up to this was: -------------------------- | ''rmlabel'', -------------------------- File to patch: viper:xen64.hg$ patch -p2 <../tmp/xend_acm_new_storage_path.diff patching file tools/python/xen/xend/XendOptions.py patching file tools/python/xen/xend/XendXSPolicyAdmin.py Hunk #4 FAILED at 101. 1 out of 4 hunks FAILED -- saving rejects to file tools/python/xen/xend/XendXSPolicyAdmin.py.rej missing header for unified diff at line 99 of patch can''t find file to patch at input line 99 Perhaps you used the wrong -p or --strip option? The text leading up to this was: -------------------------- | try: -------------------------- File to patch: _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel