Xen devel - Dec 2006 - [PATCH] Fix error message when detaching block devices

An error occurs if the first detach was successful and the 2nd one is
not (of course). Return if the 1st detach is successful, try the 2nd one
if it was not successful. Throw an error if the 2nd one fails. 
This should also fix problems I am currently seeing in the xm-test
suite.

Signed-off-by: Stefan Berger <stefanb@us.ibm.com>


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

On Fri, Dec 15, 2006 at 11:46:06PM -0500, Stefan Berger wrote:
> An error occurs if the first detach was successful and the 2nd one is
> not (of course). Return if the 1st detach is successful, try the 2nd one
> if it was not successful. Throw an error if the 2nd one fails. 
> This should also fix problems I am currently seeing in the xm-test
> suite.
> 
> Signed-off-by: Stefan Berger <stefanb@us.ibm.com>
I''ve applied this, because it looks perfectly sensible, but
I''m
concerned that this failure isn''t showing up in our xm-test runs.  What
failure are you seeing?

Ewan.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Ewan Mellor <ewan@xensource.com> wrote on 12/16/2006 07:54:01 AM:
> On Fri, Dec 15, 2006 at 11:46:06PM -0500, Stefan Berger wrote:
> 
> > An error occurs if the first detach was successful and the 2nd one is
> > not (of course). Return if the 1st detach is successful, try the 2nd 
one
> > if it was not successful. Throw an error if the 2nd one fails. 
> > This should also fix problems I am currently seeing in the xm-test
> > suite.
> > 
> > Signed-off-by: Stefan Berger <stefanb@us.ibm.com>
> 
> I''ve applied this, because it looks perfectly sensible, but
I''m
> concerned that this failure isn''t showing up in our xm-test runs. 
What
> failure are you seeing?

I got the message
REASON: xm block-detach returned invalid 256 != 0

After this fix this message was gone.

  Stefan
> 
> Ewan.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel