Charles Coffing
2004-Aug-31 19:19 UTC
[Xen-devel] [PATCH] get_current() called before set_current()
The recent change that added debugging to spinlocks (cset 1.1278.1.1) caused get_current() to be called earlier in the boot process. In fact, it is now called before set_current(). If assertions are compiled in, this ultimately causes a triple fault when Xen tries to print the banner. If assertions aren''t compiled in, memory corruption results (although currently this corruption appears to be benign.) The attached patch moves the first set_current() call a bit earlier in the boot process. Thanks, Charles
Keir Fraser
2004-Aug-31 19:41 UTC
Re: [Xen-devel] [PATCH] get_current() called before set_current()
Thanks, I''ve checked it in. It''s interesting that noone in Cambridge saw the problem when using a debug build. My guess is that we only ever momentarily cycle the power on our test boxes, and the stack happens to live in an area of memory untouched by our boot process. :-) -- Keir> The recent change that added debugging to spinlocks (cset 1.1278.1.1) > caused get_current() to be called earlier in the boot process. In fact, > it is now called before set_current(). > > If assertions are compiled in, this ultimately causes a triple fault > when Xen tries to print the banner. If assertions aren''t compiled in, > memory corruption results (although currently this corruption appears to > be benign.) > > The attached patch moves the first set_current() call a bit earlier in > the boot process.------------------------------------------------------- This SF.Net email is sponsored by BEA Weblogic Workshop FREE Java Enterprise J2EE developer tools! Get your free copy of BEA WebLogic Workshop 8.1 today. http://ads.osdn.com/?ad_id=5047&alloc_id=10808&op=click _______________________________________________ Xen-devel mailing list Xen-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/xen-devel