Xen devel - Aug 2004 - [Patch] Always call blkdev_put when destroying a vbd in device backend

The code for the block backend device in XenoLinux 2.6.8.1 doesn''t call
blkdev_put on all code paths that can destroy a vbd.  Previously,
blkdev_put was only called from vbd_shrink.  I''ve added the call to
vbd_destroy and destroy_all_vbds.

With the old code, the kernel running in domain-0 would believe the
devices exported to another domain to still be in use, even after the
other domain was shutdown.  (This was obvious when using LVM, since the
logical volumes were still listed as open, and a warning message was
printed when shutting down LVM.)  This patch should fix that.

--Michael Vrable

On Fri, Aug 27, 2004 at 04:36:22PM -0700, Michael Vrable
wrote:
> The code for the block backend device in XenoLinux 2.6.8.1 doesn''t
call
> blkdev_put on all code paths that can destroy a vbd.  Previously,
> blkdev_put was only called from vbd_shrink.  I''ve added the call
to
> vbd_destroy and destroy_all_vbds.
> 
> With the old code, the kernel running in domain-0 would believe the
> devices exported to another domain to still be in use, even after the
> other domain was shutdown.  (This was obvious when using LVM, since the
> logical volumes were still listed as open, and a warning message was
> printed when shutting down LVM.)  This patch should fix that.
Thanks.  I''ve applied the patch.

    christian



-------------------------------------------------------
This SF.Net email is sponsored by BEA Weblogic Workshop
FREE Java Enterprise J2EE developer tools!
Get your free copy of BEA WebLogic Workshop 8.1 today.
http://ads.osdn.com/?ad_id=5047&alloc_id=10808&op=click
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/xen-devel

On Sat, 28 Aug 2004, Christian Limpach wrote:
> On Fri, Aug 27, 2004 at 04:36:22PM -0700, Michael Vrable wrote:
> > The code for the block backend device in XenoLinux 2.6.8.1
doesn''t call
> > blkdev_put on all code paths that can destroy a vbd.  Previously,
> > blkdev_put was only called from vbd_shrink.  I''ve added the
call to
> > vbd_destroy and destroy_all_vbds.
> >
> > With the old code, the kernel running in domain-0 would believe the
> > devices exported to another domain to still be in use, even after the
> > other domain was shutdown.  (This was obvious when using LVM, since
the
> > logical volumes were still listed as open, and a warning message was
> > printed when shutting down LVM.)  This patch should fix that.
>
> Thanks.  I''ve applied the patch.
That patch is a bit ugly.  Version checks scattered thruout the code is not
something Linus likes.

Better to make a macro that expands to nothing when not needed, and place it
in a header file.



-------------------------------------------------------
This SF.Net email is sponsored by BEA Weblogic Workshop
FREE Java Enterprise J2EE developer tools!
Get your free copy of BEA WebLogic Workshop 8.1 today.
http://ads.osdn.com/?ad_id=5047&alloc_id=10808&op=click
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/xen-devel