Dan Carpenter
2010-Apr-22 09:39 UTC
[Ocfs2-devel] [patch] ocfs2: potential ERR_PTR dereference on error paths
If "handle" is non null at the end of the function then we assume
it's a
valid pointer and pass it to ocfs2_commit_trans();
Signed-off-by: Dan Carpenter <error27 at gmail.com>
diff --git a/fs/ocfs2/inode.c b/fs/ocfs2/inode.c
index 07cc8bb..ae8e161 100644
--- a/fs/ocfs2/inode.c
+++ b/fs/ocfs2/inode.c
@@ -558,6 +558,7 @@ static int ocfs2_truncate_for_delete(struct ocfs2_super
*osb,
handle = ocfs2_start_trans(osb, OCFS2_INODE_UPDATE_CREDITS);
if (IS_ERR(handle)) {
status = PTR_ERR(handle);
+ handle = NULL;
mlog_errno(status);
goto out;
}
Tao Ma
2010-Apr-22 13:44 UTC
[Ocfs2-devel] [patch] ocfs2: potential ERR_PTR dereference on error paths
Dan Carpenter wrote:> If "handle" is non null at the end of the function then we assume it's a > valid pointer and pass it to ocfs2_commit_trans(); > > Signed-off-by: Dan Carpenter <error27 at gmail.com> > > diff --git a/fs/ocfs2/inode.c b/fs/ocfs2/inode.c > index 07cc8bb..ae8e161 100644 > --- a/fs/ocfs2/inode.c > +++ b/fs/ocfs2/inode.c > @@ -558,6 +558,7 @@ static int ocfs2_truncate_for_delete(struct ocfs2_super *osb, > handle = ocfs2_start_trans(osb, OCFS2_INODE_UPDATE_CREDITS); > if (IS_ERR(handle)) { > status = PTR_ERR(handle); > + handle = NULL; > mlog_errno(status); > goto out; > } >Good catch. Acked-by: Tao Ma <tao.ma at oracle.com>
Joel Becker
2010-Apr-23 21:45 UTC
[Ocfs2-devel] [patch] ocfs2: potential ERR_PTR dereference on error paths
On Thu, Apr 22, 2010 at 11:39:29AM +0200, Dan Carpenter wrote:> If "handle" is non null at the end of the function then we assume it's a > valid pointer and pass it to ocfs2_commit_trans(); > > Signed-off-by: Dan Carpenter <error27 at gmail.com>This patch is now in the 'fixes' branch of ocfs2.git. Joel -- "And yet I fight, And yet I fight this battle all alone. No one to cry to; No place to call home." Joel Becker Principal Software Developer Oracle E-mail: joel.becker at oracle.com Phone: (650) 506-8127
Mark Fasheh
2010-May-06 15:24 UTC
[Ocfs2-devel] [patch] ocfs2: potential ERR_PTR dereference on error paths
On Thu, Apr 22, 2010 at 11:39:29AM +0200, Dan Carpenter wrote:> If "handle" is non null at the end of the function then we assume it's a > valid pointer and pass it to ocfs2_commit_trans(); > > Signed-off-by: Dan Carpenter <error27 at gmail.com>Acked-by: Mark Fasheh <mfasheh at suse.com> --Mark -- Mark Fasheh