Ocfs2 devel - Dec 2009 - [PATCHv2 00/12]posix_acl: Add the check items

Hi all:
This patch is moving the acl check(Null pointer and PTR_ERR) into
fs/posix_acl.c.

Thanks for Matthew Wilcox's sguuestion.

---
Signed-off-by: Liuwenyi <qingshenlwy at gmail.com>
Cc: Chris Mason <chris.mason at oracle.com>
Cc: Al Viro <viro at zeniv.linux.org.uk>
Cc: Joel Becker <joel.becker at oracle.com>
Cc: Chris Ball <cjb at laptop.org>
Cc: James Morris <jmorris at namei.org>
Cc: Serge Hallyn <serue at us.ibm.com>
Cc: Christoph Hellwig <hch at lst.de>
Cc: Andrew Morton <akpm at linux-foundation.org>
Cc: Andreas Dilger <adilger at sun.com>
Cc: Jan Kara <jack at suse.cz>
Cc: "Theodore Ts'o" <tytso at mit.edu>
Cc: David Woodhouse <dwmw2 at infradead.org>
Cc: Steven Whitehouse <swhiteho at redhat.com>
Cc: J. Bruce Fields <bfields at fieldses.org>
Cc: Neil Brown <neilb at suse.de>
Cc: Frank Filz <ffilzlnx at us.ibm.com>
Cc: Boaz Harrosh <bharrosh at panasas.com>
Cc: Mark Fasheh <mfasheh at suse.com>
Cc: Tiger Yang <tiger.yang at oracle.com>
Cc: Jeff Mahoney <jeffm at suse.com>
Cc: Alex Elder <aelder at sgi.com>
Cc: Eric Sandeen <sandeen at sandeen.net>
Cc: xfs-masters at oss.sgi.com
Cc: xfs at oss.sgi.com
Cc: reiserfs-devel at vger.kernel.org
Cc: ocfs2-devel at oss.oracle.com
Cc: linux-nfs at vger.kernel.org
Cc: linux-ext4 at vger.kernel.org
Cc: linux-btrfs at vger.kernel.org
Cc: linux-fsdevel at vger.kernel.org
Cc: linux-kernel at vger.kernel.org
Cc: cluster-devel at redhat.com
Cc: linux-mtd at lists.infradead.org

-- 
Best Regards,
Liuwenyi

I like taking these checks into posix_acl_valid, but I think the patch
submission needs a bit more work.

All the patches are extremly whitespace mangled.  And I don''t think
splitting them up makes a whole lot of sense, when we do API changes
like this we usually fix up all callers.  So please try to fix your
mailer, merged them all into one, and maybe also chose a more
descriptive subject line, e.g.

Subject: take checks for NULL and error pointers into posix_acl_valid()


And btw, at least the XFS change seems incorrect - previously we
returned NULL acl pointer and this patch changes it to -EINVAL.

I like taking these checks into posix_acl_valid, but I think the patch
submission needs a bit more work.

All the patches are extremly whitespace mangled.  And I don''t think
splitting them up makes a whole lot of sense, when we do API changes
like this we usually fix up all callers.  So please try to fix your
mailer, merged them all into one, and maybe also chose a more
descriptive subject line, e.g.

Subject: take checks for NULL and error pointers into posix_acl_valid()


And btw, at least the XFS change seems incorrect - previously we
returned NULL acl pointer and this patch changes it to -EINVAL.

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Thanks for your suggestion.

In my opinion the null point is a incorrect state for the acl, then I
return -EINVAL.

I will check this state transition in XFS.

2009/12/21 Christoph Hellwig <hch at lst.de>:
> I like taking these checks into posix_acl_valid, but I think the patch
> submission needs a bit more work.
>
> All the patches are extremly whitespace mangled. ?And I don't think
> splitting them up makes a whole lot of sense, when we do API changes
> like this we usually fix up all callers. ?So please try to fix your
> mailer, merged them all into one, and maybe also chose a more
> descriptive subject line, e.g.
>
> Subject: take checks for NULL and error pointers into posix_acl_valid()
>
>
> And btw, at least the XFS change seems incorrect - previously we
> returned NULL acl pointer and this patch changes it to -EINVAL.
>
>