Tao Ma
2009-Dec-22 02:32 UTC
[Ocfs2-devel] [PATCH] ocfs2/trivial: Use proper mask for 2 places in hearbeat.c
I just noticed today that there are 2 places of "mlog(0,...)"
in fs/ocfs2/cluster/heartbeat.c, but actually have no default
mask prefix in that file.
So change them to mlog(ML_HEARTBEAT,...).
Signed-off-by: Tao Ma <tao.ma at oracle.com>
---
fs/ocfs2/cluster/heartbeat.c | 6 ++++--
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/fs/ocfs2/cluster/heartbeat.c b/fs/ocfs2/cluster/heartbeat.c
index c452d11..eda5b8b 100644
--- a/fs/ocfs2/cluster/heartbeat.c
+++ b/fs/ocfs2/cluster/heartbeat.c
@@ -176,7 +176,8 @@ static void o2hb_write_timeout(struct work_struct *work)
static void o2hb_arm_write_timeout(struct o2hb_region *reg)
{
- mlog(0, "Queue write timeout for %u ms\n",
O2HB_MAX_WRITE_TIMEOUT_MS);
+ mlog(ML_HEARTBEAT, "Queue write timeout for %u ms\n",
+ O2HB_MAX_WRITE_TIMEOUT_MS);
cancel_delayed_work(®->hr_write_timeout_work);
reg->hr_last_timeout_start = jiffies;
@@ -874,7 +875,8 @@ static int o2hb_thread(void *data)
do_gettimeofday(&after_hb);
elapsed_msec = o2hb_elapsed_msecs(&before_hb, &after_hb);
- mlog(0, "start = %lu.%lu, end = %lu.%lu, msec = %u\n",
+ mlog(ML_HEARTBEAT,
+ "start = %lu.%lu, end = %lu.%lu, msec = %u\n",
before_hb.tv_sec, (unsigned long) before_hb.tv_usec,
after_hb.tv_sec, (unsigned long) after_hb.tv_usec,
elapsed_msec);
--
1.5.5
Sunil Mushran
2009-Dec-22 02:41 UTC
[Ocfs2-devel] [PATCH] ocfs2/trivial: Use proper mask for 2 places in hearbeat.c
Ack On Dec 21, 2009, at 6:32 PM, Tao Ma <tao.ma at oracle.com> wrote:> I just noticed today that there are 2 places of "mlog(0,...)" > in fs/ocfs2/cluster/heartbeat.c, but actually have no default > mask prefix in that file. > So change them to mlog(ML_HEARTBEAT,...). > > Signed-off-by: Tao Ma <tao.ma at oracle.com> > --- > fs/ocfs2/cluster/heartbeat.c | 6 ++++-- > 1 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/fs/ocfs2/cluster/heartbeat.c b/fs/ocfs2/cluster/ > heartbeat.c > index c452d11..eda5b8b 100644 > --- a/fs/ocfs2/cluster/heartbeat.c > +++ b/fs/ocfs2/cluster/heartbeat.c > @@ -176,7 +176,8 @@ static void o2hb_write_timeout(struct > work_struct *work) > > static void o2hb_arm_write_timeout(struct o2hb_region *reg) > { > - mlog(0, "Queue write timeout for %u ms\n", > O2HB_MAX_WRITE_TIMEOUT_MS); > + mlog(ML_HEARTBEAT, "Queue write timeout for %u ms\n", > + O2HB_MAX_WRITE_TIMEOUT_MS); > > cancel_delayed_work(®->hr_write_timeout_work); > reg->hr_last_timeout_start = jiffies; > @@ -874,7 +875,8 @@ static int o2hb_thread(void *data) > do_gettimeofday(&after_hb); > elapsed_msec = o2hb_elapsed_msecs(&before_hb, &after_hb); > > - mlog(0, "start = %lu.%lu, end = %lu.%lu, msec = %u\n", > + mlog(ML_HEARTBEAT, > + "start = %lu.%lu, end = %lu.%lu, msec = %u\n", > before_hb.tv_sec, (unsigned long) before_hb.tv_usec, > after_hb.tv_sec, (unsigned long) after_hb.tv_usec, > elapsed_msec); > -- > 1.5.5 > > > _______________________________________________ > Ocfs2-devel mailing list > Ocfs2-devel at oss.oracle.com > http://oss.oracle.com/mailman/listinfo/ocfs2-devel