Ocfs2 devel - Sep 2009 - [PATCH] ocfs2: remove DIR check in ocfs2_link

Maybe so. But I see no harm leaving the check in.

On Sep 9, 2009, at 9:58 AM, Wengang Wang <wen.gang.wang at oracle.com>  
wrote:
>  there is check on the inode whether it is a DIR in ocfs2_link().
> the same check is done in vfs_link already, so remove it from  
> ocfs2_link().
>
> Signed-off-by: Wengang Wang <wen.gang.wang at oracle.com>
> ---
> fs/ocfs2/namei.c |    3 ---
> 1 files changed, 0 insertions(+), 3 deletions(-)
>
> diff --git a/fs/ocfs2/namei.c b/fs/ocfs2/namei.c
> index 33464c6..35809c0 100644
> --- a/fs/ocfs2/namei.c
> +++ b/fs/ocfs2/namei.c
> @@ -633,9 +633,6 @@ static int ocfs2_link(struct dentry *old_dentry,
>           old_dentry->d_name.len, old_dentry->d_name.name,
>           dentry->d_name.len, dentry->d_name.name);
>
> -    if (S_ISDIR(inode->i_mode))
> -        return -EPERM;
> -
>    err = ocfs2_inode_lock(dir, &parent_fe_bh, 1);
>    if (err < 0) {
>        if (err != -ENOENT)
> -- 
> 1.6.2.5
>
>
> _______________________________________________
> Ocfs2-devel mailing list
> Ocfs2-devel at oss.oracle.com
> http://oss.oracle.com/mailman/listinfo/ocfs2-devel

there is check on the inode whether it is a DIR in ocfs2_link().
the same check is done in vfs_link already, so remove it from ocfs2_link().

Signed-off-by: Wengang Wang <wen.gang.wang at oracle.com>
---
 fs/ocfs2/namei.c |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)

diff --git a/fs/ocfs2/namei.c b/fs/ocfs2/namei.c
index 33464c6..35809c0 100644
--- a/fs/ocfs2/namei.c
+++ b/fs/ocfs2/namei.c
@@ -633,9 +633,6 @@ static int ocfs2_link(struct dentry *old_dentry,
 		   old_dentry->d_name.len, old_dentry->d_name.name,
 		   dentry->d_name.len, dentry->d_name.name);
 
-	if (S_ISDIR(inode->i_mode))
-		return -EPERM;
-
 	err = ocfs2_inode_lock(dir, &parent_fe_bh, 1);
 	if (err < 0) {
 		if (err != -ENOENT)
-- 
1.6.2.5