Just did a sync with revision 30 from the repository. It fails to insmod. /lib/modules/2.4.22-1.2149.nptl/unsupported/fs/ocfs2.o: unresolved symbol OCFS_SB_GET_KDEV It looks like the latest revision removed the definition of OCFS_SB_GET_KDEV in src/inc/ocfs.h but is still using the macro :( John
Yea, that would be my fault. Let me get a fix together>-----Original Message----- >From: Villalovos, John L >Sent: Tuesday, February 10, 2004 4:07 PM >To: ocfs2-devel@oss.oracle.com >Cc: Lynch, Rusty >Subject: Revision 30 fails to insmod > >Just did a sync with revision 30 from the repository. > >It fails to insmod. > >/lib/modules/2.4.22-1.2149.nptl/unsupported/fs/ocfs2.o: unresolvedsymbol>OCFS_SB_GET_KDEV > >It looks like the latest revision removed the definition of >OCFS_SB_GET_KDEV in src/inc/ocfs.h but is still using the macro :( > >John
On Tue, Feb 10, 2004 at 04:07:26PM -0800, Villalovos, John L wrote:> Just did a sync with revision 30 from the repository. > > It fails to insmod. > > /lib/modules/2.4.22-1.2149.nptl/unsupported/fs/ocfs2.o: unresolved > symbol OCFS_SB_GET_KDEV > > It looks like the latest revision removed the definition of > OCFS_SB_GET_KDEV in src/inc/ocfs.h but is still using the macro :(Here is a fix --rusty Index: src/inc/ocfs.h ==================================================================--- src/inc/ocfs.h (revision 30) +++ src/inc/ocfs.h (working copy) @@ -1107,7 +1107,7 @@ typedef long sector_t; #define map_bh(bh, sb, blk) \ ({ \ - bh->b_dev = OCFS_SB_GET_KDEV(sb); \ + bh->b_dev = sb->s_dev; \ bh->b_blocknr = blk; \ bh->b_state |= (1UL << BH_Mapped); \ })
Excellent. That fixed it for me. John> -----Original Message----- > From: ocfs2-devel-bounces@oss.oracle.com > [mailto:ocfs2-devel-bounces@oss.oracle.com] On Behalf Of Rusty Lynch > Sent: Tuesday, February 10, 2004 4:26 PM > To: manish.singh@oracle.com > Cc: ocfs2-devel@oss.oracle.com > Subject: Re: [Ocfs2-devel] Revision 30 fails to insmod > > > On Tue, Feb 10, 2004 at 04:07:26PM -0800, Villalovos, John L wrote: > > Just did a sync with revision 30 from the repository. > > > > It fails to insmod. > > > > /lib/modules/2.4.22-1.2149.nptl/unsupported/fs/ocfs2.o: unresolved > > symbol OCFS_SB_GET_KDEV > > > > It looks like the latest revision removed the definition of > > OCFS_SB_GET_KDEV in src/inc/ocfs.h but is still using the macro :( > > Here is a fix > > --rusty > > Index: src/inc/ocfs.h > ==================================================================> --- src/inc/ocfs.h (revision 30) > +++ src/inc/ocfs.h (working copy) > @@ -1107,7 +1107,7 @@ > typedef long sector_t; > #define map_bh(bh, sb, blk) \ > ({ \ > - bh->b_dev = OCFS_SB_GET_KDEV(sb); \ > + bh->b_dev = sb->s_dev; \ > bh->b_blocknr = blk; \ > bh->b_state |= (1UL << BH_Mapped); \ > }) > _______________________________________________ > Ocfs2-devel mailing list > Ocfs2-devel@oss.oracle.com > http://oss.oracle.com/mailman/listinfo/ocfs2-devel >
On Tue, Feb 10, 2004 at 04:26:21PM -0800, Rusty Lynch wrote:> On Tue, Feb 10, 2004 at 04:07:26PM -0800, Villalovos, John L wrote: > > Just did a sync with revision 30 from the repository. > > > > It fails to insmod. > > > > /lib/modules/2.4.22-1.2149.nptl/unsupported/fs/ocfs2.o: unresolved > > symbol OCFS_SB_GET_KDEV > > > > It looks like the latest revision removed the definition of > > OCFS_SB_GET_KDEV in src/inc/ocfs.h but is still using the macro :( > > Here is a fixThanks, committed to the tree. -Manish