Anthony Liguori
2007-Apr-18 17:49 UTC
[RFC PATCH 35/35] Add Xen virtual block device driver.
Ian Pratt wrote:>> This seems to be pretty evil and creating interesting failure >> conditions for users who load IDE or SCSI modules. I've seen >> it trip up a number of people in the past. I think we should >> only ever use the major number that was actually allocated to us. >> > > We certainly should be pushing everyone toward using the 'xdX' etc > devices that are allocated to us. However, the installers of certain > older distros and other user space tools won't except anything other > than hdX/sdX, so its useful from a compatibility POV even if it never > goes into mainline, which I agree it probably shouldn't. >Then perhaps we should deprecate non xd block devices starting in the near future (3.0.3?). We probably need to have it deprecated for a few releases since I think most people are not using xd at this point... Regards, Anthony Liguori> Ian >
> This is another thing that has always put me off. The > virtual block device driver has the ability to masquerade as > other types of block devices. It actually claims to be an > IDE or SCSI device allocating the appropriate major/minor numbers. > > This seems to be pretty evil and creating interesting failure > conditions for users who load IDE or SCSI modules. I've seen > it trip up a number of people in the past. I think we should > only ever use the major number that was actually allocated to us.We certainly should be pushing everyone toward using the 'xdX' etc devices that are allocated to us. However, the installers of certain older distros and other user space tools won't except anything other than hdX/sdX, so its useful from a compatibility POV even if it never goes into mainline, which I agree it probably shouldn't. Ian
Ian Pratt wrote:>>This is another thing that has always put me off. The >>virtual block device driver has the ability to masquerade as >>other types of block devices. It actually claims to be an >>IDE or SCSI device allocating the appropriate major/minor numbers. >> >>This seems to be pretty evil and creating interesting failure >>conditions for users who load IDE or SCSI modules. I've seen >>it trip up a number of people in the past. I think we should >>only ever use the major number that was actually allocated to us. > > > We certainly should be pushing everyone toward using the 'xdX' etc > devices that are allocated to us. However, the installers of certain > older distros and other user space tools won't except anything other > than hdX/sdX, so its useful from a compatibility POV even if it never > goes into mainline, which I agree it probably shouldn't.Yes, this is true. Red Hat installer guys grumbled at me when I wrote the 'sx8' block driver: since it wasn't hda/sda, they had to write special code for it, as they apparently must do for any new block driver "class". SuSE and other distros are probably similar, since each block driver provides its own special behaviors and feature exports. I should have spoken up a long time ago about this, but anyway: An IBM hypervisor on ppc64 communicates uses SCSI RPC messages. I think this would be quite nice for Xen, because SCSI (a) is a message-based model, and (b) implementing block using SCSI has a very high Just Works(tm) value which cannot be ignored. And perhaps (c) SCSI target code already exists, so implementing the server side doesn't require starting from scratch, but rather simply connecting the Legos. Jeff
Arjan van de Ven
2007-Apr-18 17:49 UTC
[RFC PATCH 35/35] Add Xen virtual block device driver.
On Wed, 2006-03-22 at 16:52 +0000, Ian Pratt wrote:> > This is another thing that has always put me off. The > > virtual block device driver has the ability to masquerade as > > other types of block devices. It actually claims to be an > > IDE or SCSI device allocating the appropriate major/minor numbers. > > > > This seems to be pretty evil and creating interesting failure > > conditions for users who load IDE or SCSI modules. I've seen > > it trip up a number of people in the past. I think we should > > only ever use the major number that was actually allocated to us. > > We certainly should be pushing everyone toward using the 'xdX' etc > devices that are allocated to us.yes but you are faking something stupid ;) You aren't ide, you don't take the IDE ioctls. So please just nuke this bit..
Possibly Parallel Threads
- [RFC PATCH 35/35] Add Xen virtual block device driver.
- pciback for usb-controller and usb-storage on x86_64 ends in Oops
- pciback for usb-controller and usb-storage on x86_64 ends in Oops
- How HVM domain distingush ioemu disk and VBD disk
- Dom0 searching for NFS root