Boris Tonofa
2025-Jun-17 17:02 UTC
Correct author attribution for commits df3f903d6…, 80916d0d3… and status of PR #575
Hello, On 13 June 2025 I submitted three patches ? to openssh-unix-dev@ and as GitHub pull requests: [PATCH] fix incorrect overflow check (22:26) ? PR #573 [PATCH] fix memory leak in client_global_hostkeys_prove_confirm (22:44) ? PR #574 [PATCH] fix memory leak in mux_client_request_stdio_fwd (23:23) ? PR #575 Patches #1 and #2 have already been merged: df3f903d616763a105570610a616dacf0f83438e ? upstream: Fix overflow check in sshbuf_dup_string 80916d0d3794e2f92dd6998d7c45daba484e4f18 ? upstream: Plug mem leak. Patch from afonot via GitHub PR #574, ok djm@ In both commits my GitHub username afonot appears only inside the message and the Author field is missing. Could you please amend the commits so that the Author line reads: Author: Boris Tonofa <b.tonofa at ideco.ru> PR #575 has not yet been merged. Is there an issue with the patch, or has it simply not been processed? If the patch is acceptable, I would appreciate it if the same author line were used when it is integrated. Thank you very much for your time! Best regards, Boris Tonofa (afonot)
Damien Miller
2025-Jun-18 12:34 UTC
Re: Correct author attribution for commits df3f903d6…, 80916d0d3… and status of PR #575
On Tue, 17 Jun 2025, Boris Tonofa wrote:> Hello, > > On 13 June 2025 I submitted three patches ? to openssh-unix-dev@ and as > GitHub pull requests: > > [PATCH] fix incorrect overflow check (22:26) ? PR #573 > > [PATCH] fix memory leak in client_global_hostkeys_prove_confirm > (22:44) ? PR #574 > > [PATCH] fix memory leak in mux_client_request_stdio_fwd (23:23) ? > PR #575 > > Patches #1 and #2 have already been merged: > > df3f903d616763a105570610a616dacf0f83438e ? upstream: Fix overflow > check in sshbuf_dup_string > > 80916d0d3794e2f92dd6998d7c45daba484e4f18 ? upstream: Plug mem leak. > Patch from afonot via GitHub PR #574, ok djm@ > > In both commits my GitHub username afonot appears only inside the > message and the Author field is missing. > Could you please amend the commits so that the Author line reads:No unfortunately. These commits were merged to the upstream OpenSSH repository in the OpenBSD project and then synced back to the portable OpenSSH project. We don't rewrite history in the portable OpenSSH repository. -d