Gustavo A. R. Silva
2025-Apr-22 15:44 UTC
[PATCH][next] drm/nouveau: disp: Use __member_size() helper
Use __member_size() to get the size of the flex-array member at compile time, instead of the convoluted expression `__struct_size(p) - sizeof(*p)` Signed-off-by: Gustavo A. R. Silva <gustavoars at kernel.org> --- drivers/gpu/drm/nouveau/dispnv50/disp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/dispnv50/disp.c b/drivers/gpu/drm/nouveau/dispnv50/disp.c index 725331638a15..9bed728cb00e 100644 --- a/drivers/gpu/drm/nouveau/dispnv50/disp.c +++ b/drivers/gpu/drm/nouveau/dispnv50/disp.c @@ -776,7 +776,7 @@ nv50_hdmi_enable(struct drm_encoder *encoder, struct nouveau_crtc *nv_crtc, const u8 rekey = 56; /* binary driver, and tegra, constant */ u32 max_ac_packet; DEFINE_RAW_FLEX(struct nvif_outp_infoframe_v0, args, data, 17); - const u8 data_len = __struct_size(args) - sizeof(*args); + const u8 data_len = __member_size(args->data); int ret, size; max_ac_packet = mode->htotal - mode->hdisplay; -- 2.43.0
Kees Cook
2025-Apr-22 15:49 UTC
[PATCH][next] drm/nouveau: disp: Use __member_size() helper
On Tue, Apr 22, 2025 at 09:44:56AM -0600, Gustavo A. R. Silva wrote:> Use __member_size() to get the size of the flex-array member at compile > time, instead of the convoluted expression `__struct_size(p) - sizeof(*p)` > > Signed-off-by: Gustavo A. R. Silva <gustavoars at kernel.org>Reviewed-by: Kees Cook <kees at kernel.org> -- Kees Cook
Danilo Krummrich
2025-Apr-23 15:34 UTC
[PATCH][next] drm/nouveau: disp: Use __member_size() helper
On Tue, Apr 22, 2025 at 09:44:56AM -0600, Gustavo A. R. Silva wrote:> Use __member_size() to get the size of the flex-array member at compile > time, instead of the convoluted expression `__struct_size(p) - sizeof(*p)` > > Signed-off-by: Gustavo A. R. Silva <gustavoars at kernel.org>Applied to drm-misc-next, thanks!