openssh bugs - May 2024 - [Bug 3692] New: rekey.sh doesn't actually test different algorithms

https://bugzilla.mindrot.org/show_bug.cgi?id=3692

            Bug ID: 3692
           Summary: rekey.sh doesn't actually test different algorithms
           Product: Portable OpenSSH
           Version: 9.7p1
          Hardware: Other
                OS: Linux
            Status: NEW
          Severity: enhancement
          Priority: P5
         Component: Regression tests
          Assignee: unassigned-bugs at mindrot.org
          Reporter: nreilly at blackberry.com

In rekey.sh there is a function ssh_data_rekeying(). It sets the first
parameter as _kexopt but then 2 lines later tests _kexopts - note the
trailing "s":

ssh_data_rekeying()
{
        _kexopt=$1 ; shift
        _opts="$@"
        if ! test -z "$_kexopts" ; then
                cp $OBJ/sshd_proxy_bak $OBJ/sshd_proxy
                echo "$_kexopt" >> $OBJ/sshd_proxy
                _opts="$_opts -o$_kexopt"
        fi

This means that the various algorithms never are set and so it tests
the same default algorithm over and over.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3692

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |djm at mindrot.org

--- Comment #1 from Damien Miller <djm at mindrot.org> ---
sigh, I wonder which idiot broke the test?
> djm at cvs.openbsd.org 2014/04/21 22:15:37
> [dhgex.sh integrity.sh kextype.sh rekey.sh try-ciphers.sh]
> repair regress tests broken by server-side default cipher/kex/mac
> changes by ensuring that the option under test is included in the
> server's algorithm list
oh.

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3692

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |3674
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from Damien Miller <djm at mindrot.org> ---
Fixed in git. This will be in the openssh-9.8 release - thanks.


Referenced Bugs:

https://bugzilla.mindrot.org/show_bug.cgi?id=3674
[Bug 3674] Tracking bug for OpenSSH 9.8
-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.