This patch: - adds --prefix option to service::install in mongrel-service plugin - fixes bug with config values merging in the service - enables gemplugins in the service. Questions: - why the load_plugins command was commented out? It seems working for me. - why bin/mongrel_rails_service and bin/mongrel_rails_svc still in the main package? - a lot of code is duplicated in both versions (standalone mongrel and service) - a bit of refactoring could help Anyway, this --prefix option is scratching my itch - I did by overwriting the mongrel itself and this is much cleaner. Thanks a lot! J. -------------- next part -------------- A non-text attachment was scrubbed... Name: diff Type: application/octet-stream Size: 3981 bytes Desc: not available Url : http://rubyforge.org/pipermail/mongrel-users/attachments/20060717/d09d19d1/attachment-0001.obj
On Mon, 2006-07-17 at 20:33 +0200, Jan Svitok wrote:> This patch: > > - adds --prefix option to service::install in mongrel-service plugin > - fixes bug with config values merging in the service > - enables gemplugins in the service. >Thanks, I hadn''t hit the win32 side of things yet. I usually do those before I make a release official.> Questions: > > - why the load_plugins command was commented out? It seems working for me.Not sure.> - why bin/mongrel_rails_service and bin/mongrel_rails_svc still in the > main package?Some people still had these. I''ll be deprecating them in 0.4.> - a lot of code is duplicated in both versions (standalone mongrel and > service) - a bit of refactoring could help >All of that goes away with the new 0.3.13.x releases which you don''t even use those. There''s just a plugin that adds the service commands.> Anyway, this --prefix option is scratching my itch - I did by > overwriting the mongrel itself and this is much cleaner. Thanks a lot!Thanks again. -- Zed A. Shaw http://www.zedshaw.com/ http://mongrel.rubyforge.org/ http://www.railsmachine.com/ -- Need Mongrel support?
On 7/17/06, Jan Svitok <jan.svitok at gmail.com> wrote: [snip]> > - why the load_plugins command was commented out? It seems working for me.Was commented because load_plugins raised problems with win32-service, making rials halt and crash sometimes (not always).> - why bin/mongrel_rails_service and bin/mongrel_rails_svc still in the > main package? > - a lot of code is duplicated in both versions (standalone mongrel and > service) - a bit of refactoring could helpmongrel_service was made to replace mongrel_rails_* files, as Zed said, these will go away with the upcoming 0.4 release. -- Luis Lavena Multimedia systems - Leaders are made, they are not born. They are made by hard effort, which is the price which all of us must pay to achieve any goal that is worthwhile. Vince Lombardi