This is a small patch that Sam came up with for me, it will allow drivers to know when a vlan attaches. It is transparent to any code that doesn't want to change, but this will allow my drivers to finally utilize the vlan hardware filter (something Linux has had for ever but we lacked). My test group has done some basic testing of this and it is working great. But we wanted to give any vlan users a chance to see, ask questions, or whatever before its committed. Jack
On 6/10/08, Jack Vogel <jfvogel@gmail.com> wrote:> This is a small patch that Sam came up with for me, it will allow > drivers to know > when a vlan attaches. > > It is transparent to any code that doesn't want to change, but this > will allow my > drivers to finally utilize the vlan hardware filter (something Linux has had > for > ever but we lacked). > > My test group has done some basic testing of this and it is working great. > But we wanted to give any vlan users a chance to see, ask questions, or > whatever before its committed. > > Jack >Sigh, sorry, here's the actual patch :) Jack -------------- next part -------------- A non-text attachment was scrubbed... Name: vlan.patch Type: text/x-patch Size: 1394 bytes Desc: not available Url : http://lists.freebsd.org/pipermail/freebsd-stable/attachments/20080610/08448448/vlan.bin
On Tue, Jun 10, 2008 at 09:51:53AM -0700, Jack Vogel wrote: > This is a small patch that Sam came up with for me, it will allow > drivers to know > when a vlan attaches. > > It is transparent to any code that doesn't want to change, but this > will allow my > drivers to finally utilize the vlan hardware filter (something Linux has had for > ever but we lacked). > Just curious, is there any rule how to use that new capability? Because drivers will receive events whenever VLAN tags are added/removed they would know how to act for these events. If promiscuous mode is on for interface, driver should not filter any VLAN tagged frames, right? If users want to disable VLAN hardware filtering feature what is best way to perform this? Introducing a new flag like IFCAP_VLAN_HWFILT or add a new sysctl that control this feature? I guess VIA Rhine III also have VLAN hardware filtering capability so it would be even better if we have a way to share common part. > My test group has done some basic testing of this and it is working great. > But we wanted to give any vlan users a chance to see, ask questions, or > whatever before its committed. > > Jack -- Regards, Pyun YongHyeon