Sasha Levin
2023-Dec-11 13:53 UTC
[PATCH AUTOSEL 6.1 13/29] nouveau/tu102: flush all pdbs on vmm flush
From: Dave Airlie <airlied at redhat.com> [ Upstream commit cb9c919364653eeafb49e7ff5cd32f1ad64063ac ] This is a hack around a bug exposed with the GSP code, I'm not sure what is happening exactly, but it appears some of our flushes don't result in proper tlb invalidation for out BAR2 and we get a BAR2 fault from GSP and it all dies. Signed-off-by: Dave Airlie <airlied at redhat.com> Signed-off-by: Danilo Krummrich <dakr at redhat.com> Link: https://patchwork.freedesktop.org/patch/msgid/20231130010852.4034774-1-airlied at gmail.com Signed-off-by: Sasha Levin <sashal at kernel.org> --- drivers/gpu/drm/nouveau/nvkm/subdev/mmu/vmmtu102.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/mmu/vmmtu102.c b/drivers/gpu/drm/nouveau/nvkm/subdev/mmu/vmmtu102.c index 6cb5eefa45e9a..5a08458fe1b7f 100644 --- a/drivers/gpu/drm/nouveau/nvkm/subdev/mmu/vmmtu102.c +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/mmu/vmmtu102.c @@ -31,7 +31,7 @@ tu102_vmm_flush(struct nvkm_vmm *vmm, int depth) type |= 0x00000001; /* PAGE_ALL */ if (atomic_read(&vmm->engref[NVKM_SUBDEV_BAR])) - type |= 0x00000004; /* HUB_ONLY */ + type |= 0x00000006; /* HUB_ONLY | ALL PDB (hack) */ mutex_lock(&vmm->mmu->mutex); -- 2.42.0
Timur Tabi
2023-Dec-11 14:10 UTC
[PATCH AUTOSEL 6.1 13/29] nouveau/tu102: flush all pdbs on vmm flush
On Mon, 2023-12-11 at 08:53 -0500, Sasha Levin wrote:> This is a hack around a bug exposed with the GSP code, I'm not sure > what is happening exactly, but it appears some of our flushes don't > result in proper tlb invalidation for out BAR2 and we get a BAR2 > fault from GSP and it all dies.Do we still want this hack on older kernels that don't support GSP?