Swfdec - Sep 2008 - [Bug 17633] New: ijg libjpeg based jpeg decoder patch

http://bugs.freedesktop.org/show_bug.cgi?id=17633

           Summary: ijg libjpeg based jpeg decoder patch
           Product: swfdec
           Version: git
          Platform: Other
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: medium
         Component: library
        AssignedTo: swfdec at lists.freedesktop.org
        ReportedBy: riccardo at datahost.it
         QAContact: swfdec at lists.freedesktop.org


Created an attachment (id=18963)
 --> (http://bugs.freedesktop.org/attachment.cgi?id=18963)
libjpeg based jpeg decoder

So this new revision have a couple of changes:

- fix a brown paper bag, i was reading the compressed data 1 (!!) byte at time,
because the silly of me not only was using sizeof() on a malloc'ed area but
i
was even dereferencing it. Should now be a lot faster.

- improve the jpeg fscked soi workaround, now it doesn't try to patch the
wrong
soi, if there is a sane soi after that it justs skips data. Don't think the
old
was correct because libjpeg refused to decode the picture.

Feel free to use this bug to track regressions with dsjpeg.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.

http://bugs.freedesktop.org/show_bug.cgi?id=17633





--- Comment #1 from Riccardo Magliocchetti <riccardo at datahost.it> 
2008-09-17 09:59:02 PST ---
(In reply to comment #0)
> - improve the jpeg fscked soi workaround, now it doesn't try to patch
the wrong
> soi, if there is a sane soi after that it justs skips data. Don't think
the old
> was correct because libjpeg refused to decode the picture.
Just noticed it fixes some testcase like the orisins game but there are stil
cases like pitch hitter 2 that are not working. So not ready for inclusion.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.

http://bugs.freedesktop.org/show_bug.cgi?id=17633


Riccardo Magliocchetti <riccardo at datahost.it> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |enhancement




--- Comment #2 from Riccardo Magliocchetti <riccardo at datahost.it> 
2008-09-21 08:12:08 PST ---
Another site with jpeg image corruption:
http://thefiresign.com/firesign_121706.swf

Note to self: I've checked gnash and it works fine for both pinch hitter and
the one above, there should be something dumb i'm doing.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.

http://bugs.freedesktop.org/show_bug.cgi?id=17633


Riccardo Magliocchetti <riccardo at datahost.it> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #18963|0                           |1
        is obsolete|                            |




--- Comment #3 from Riccardo Magliocchetti <riccardo at datahost.it> 
2008-12-27 03:36:38 PST ---
Created an attachment (id=21505)
 --> (http://bugs.freedesktop.org/attachment.cgi?id=21505)
ijg libjepg based jpeg decoding - v9

This is an updated version against origin/master with these changes:

- better bogus jpeg header workaround, now same as gnash 
- handling of cmyk and grayscale color space
- every file that previously failed now works \o/

The patch is till not ready for inclusion because:

- it needs review :)
- swfdec_jpeg_cmyk_to_argb loop does not compile
- more testing to sort out if i can remove ifdeffed out code in
swfdec_jpeg_decode_argb, think so


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.

http://bugs.freedesktop.org/show_bug.cgi?id=17633


Riccardo Magliocchetti <riccardo at datahost.it> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21505|0                           |1
        is obsolete|                            |




--- Comment #4 from Riccardo Magliocchetti <riccardo at datahost.it> 
2008-12-28 08:05:51 PST ---
Created an attachment (id=21518)
 --> (http://bugs.freedesktop.org/attachment.cgi?id=21518)
ijg libjepg based jpeg decoding - v10

Changelog from previous version:

- reworked swfdec_jpeg_x_to_argb functions a bit: cinfo->output_componenents
is
used to loop over the input image and a check of its expected size is added.
Side effect is that swfdec_jpeg_cmyk_to_argb now compiles.
- removed code under #if 0


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.