Danilo Krummrich
2023-Sep-27 16:59 UTC
[Nouveau] [PATCH drm-misc-next v4 7/8] drm/gpuvm: generalize dma_resv/extobj handling and GEM validation
On 9/22/23 13:45, Boris Brezillon wrote:> On Wed, 20 Sep 2023 16:42:40 +0200 > Danilo Krummrich <dakr at redhat.com> wrote: > >> + /** >> + * @DRM_GPUVM_RESV_PROTECTED: GPUVM is protected externally by the >> + * GPUVM's &dma_resv lock > > I think we need to be more specific, and list the fields/operations > that need to be externally protected when DRM_GPUVM_RESV_PROTECTED is > set.I agree, we should probably keep a list somewhere. However, there are also lockdep asserts where a lock is required to be held.> >> + */ >> + DRM_GPUVM_RESV_PROTECTED = (1 << 0), >