Danilo Krummrich
2023-Aug-05 16:00 UTC
[Nouveau] [PATCH drm-misc-next] nouveau/dmem: fix copy-paste error in nouveau_dmem_migrate_chunk()
Fix call to nouveau_fence_emit() with wrong channel parameter. Fixes: 7f2a0b50b2b2 ("drm/nouveau: fence: separate fence alloc and emit") Signed-off-by: Danilo Krummrich <dakr at redhat.com> --- drivers/gpu/drm/nouveau/nouveau_dmem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_dmem.c b/drivers/gpu/drm/nouveau/nouveau_dmem.c index 4ad40e42cae1..61e84562094a 100644 --- a/drivers/gpu/drm/nouveau/nouveau_dmem.c +++ b/drivers/gpu/drm/nouveau/nouveau_dmem.c @@ -678,7 +678,7 @@ static void nouveau_dmem_migrate_chunk(struct nouveau_drm *drm, } if (!nouveau_fence_new(&fence)) - nouveau_fence_emit(fence, chunk->drm->dmem->migrate.chan); + nouveau_fence_emit(fence, drm->dmem->migrate.chan); migrate_vma_pages(args); nouveau_dmem_fence_done(&fence); nouveau_pfns_map(svmm, args->vma->vm_mm, args->start, pfns, i); base-commit: 82d750e9d2f5d0594c8f7057ce59127e701af781 -- 2.41.0
Karol Herbst
2023-Aug-05 17:02 UTC
[Nouveau] [PATCH drm-misc-next] nouveau/dmem: fix copy-paste error in nouveau_dmem_migrate_chunk()
On Sat, Aug 5, 2023 at 6:00?PM Danilo Krummrich <dakr at redhat.com> wrote:> > Fix call to nouveau_fence_emit() with wrong channel parameter. > > Fixes: 7f2a0b50b2b2 ("drm/nouveau: fence: separate fence alloc and emit") > Signed-off-by: Danilo Krummrich <dakr at redhat.com> > --- > drivers/gpu/drm/nouveau/nouveau_dmem.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/nouveau/nouveau_dmem.c b/drivers/gpu/drm/nouveau/nouveau_dmem.c > index 4ad40e42cae1..61e84562094a 100644 > --- a/drivers/gpu/drm/nouveau/nouveau_dmem.c > +++ b/drivers/gpu/drm/nouveau/nouveau_dmem.c > @@ -678,7 +678,7 @@ static void nouveau_dmem_migrate_chunk(struct nouveau_drm *drm, > } > > if (!nouveau_fence_new(&fence)) > - nouveau_fence_emit(fence, chunk->drm->dmem->migrate.chan); > + nouveau_fence_emit(fence, drm->dmem->migrate.chan); > migrate_vma_pages(args); > nouveau_dmem_fence_done(&fence); > nouveau_pfns_map(svmm, args->vma->vm_mm, args->start, pfns, i); > > base-commit: 82d750e9d2f5d0594c8f7057ce59127e701af781 > -- > 2.41.0 >Reviewed-by: Karol Herbst <kherbst at redhat.com>
Reasonably Related Threads
- [PATCH drm-misc-next] drm/nouveau: fence: fix undefined fence state after emit
- [PATCH v3] nouveau/dmem: handle kcalloc() allocation failure
- [PATCH v3 0/4] nouveau/hmm: map pages after migration
- [PATCH -next] drm/nouveau/dmem: remove set but not used variable 'drm'
- [PATCH] drm/nouveau/dmem: Fix a NULL vs IS_ERR() check