Cc: Ben Skeggs <bskeggs at redhat.com> Cc: Lyude Paul <lyude at redhat.com> Fixes: f530bc60a30b ("drm/nouveau/disp: move HDMI config into acquire + infoframe methods") Signed-off-by: Karol Herbst <kherbst at redhat.com> --- drivers/gpu/drm/nouveau/nvkm/engine/disp/g94.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/disp/g94.c b/drivers/gpu/drm/nouveau/nvkm/engine/disp/g94.c index a4853c4e5ee3..67ef889a0c5f 100644 --- a/drivers/gpu/drm/nouveau/nvkm/engine/disp/g94.c +++ b/drivers/gpu/drm/nouveau/nvkm/engine/disp/g94.c @@ -295,6 +295,7 @@ g94_sor = { .clock = nv50_sor_clock, .war_2 = g94_sor_war_2, .war_3 = g94_sor_war_3, + .hdmi = &g84_sor_hdmi, .dp = &g94_sor_dp, }; -- 2.41.0
Reviewed-by: Lyude Paul <lyude at redhat.com> But seeing as I looked at this + some other patches yesterday I assume there's still more to this? On Fri, 2023-06-30 at 18:06 +0200, Karol Herbst wrote:> Cc: Ben Skeggs <bskeggs at redhat.com> > Cc: Lyude Paul <lyude at redhat.com> > Fixes: f530bc60a30b ("drm/nouveau/disp: move HDMI config into acquire + infoframe methods") > Signed-off-by: Karol Herbst <kherbst at redhat.com> > --- > drivers/gpu/drm/nouveau/nvkm/engine/disp/g94.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/disp/g94.c b/drivers/gpu/drm/nouveau/nvkm/engine/disp/g94.c > index a4853c4e5ee3..67ef889a0c5f 100644 > --- a/drivers/gpu/drm/nouveau/nvkm/engine/disp/g94.c > +++ b/drivers/gpu/drm/nouveau/nvkm/engine/disp/g94.c > @@ -295,6 +295,7 @@ g94_sor = { > .clock = nv50_sor_clock, > .war_2 = g94_sor_war_2, > .war_3 = g94_sor_war_3, > + .hdmi = &g84_sor_hdmi, > .dp = &g94_sor_dp, > }; >-- Cheers, Lyude Paul (she/her) Software Engineer at Red Hat
Would a corresponding imperative description be helpful also for such a small change? See also: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.4#n94 Regards, Markus
Maybe Matching Threads
- [PATCH] drm/nouveau/disp/g94: enable HDMI
- [PATCH] nv50/disp: Fix modeset on G94
- [PATCH] nv50/disp: Fix modeset on G94
- [PATCH] drm/nouveau/disp: Fix missing backlight control on Macbook 5, 1
- [Bug 87885] New: Fan speed of Nvidia GeForce 9600GT (G94) constantly too high