Jason Wang
2023-Mar-17 03:22 UTC
[PATCH v2 2/2] vdpa/mlx5: Make VIRTIO_NET_F_MRG_RXBUF off by default
On Wed, Mar 15, 2023 at 3:28?PM Eli Cohen <elic at nvidia.com> wrote:> > One can still enable it when creating the vdpa device using vdpa tool by > providing features that include it. > > For example: > $ vdpa dev add name vdpa0 mgmtdev pci/0000:86:00.2 device_features 0x300cb982b > > Please be aware that this feature was not supported before the previous > patch in this list was introduced so we don't change user experience.Patch looks good but we need to document why we disable mrg rxbuf by default in the changlog. With that, Acked-by: Jason Wang <jasowang at redhat.com> Thanks> > Signed-off-by: Eli Cohen <elic at nvidia.com> > --- > drivers/vdpa/mlx5/net/mlx5_vnet.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/vdpa/mlx5/net/mlx5_vnet.c b/drivers/vdpa/mlx5/net/mlx5_vnet.c > index 4abc3a4ee515..3858ba1e8975 100644 > --- a/drivers/vdpa/mlx5/net/mlx5_vnet.c > +++ b/drivers/vdpa/mlx5/net/mlx5_vnet.c > @@ -3154,6 +3154,8 @@ static int mlx5_vdpa_dev_add(struct vdpa_mgmt_dev *v_mdev, const char *name, > return -EINVAL; > } > device_features &= add_config->device_features; > + } else { > + device_features &= ~BIT_ULL(VIRTIO_NET_F_MRG_RXBUF); > } > if (!(device_features & BIT_ULL(VIRTIO_F_VERSION_1) && > device_features & BIT_ULL(VIRTIO_F_ACCESS_PLATFORM))) { > -- > 2.38.1 >