bugzilla-daemon at mindrot.org
2023-Jan-31 19:43 UTC
[Bug 3530] New: AC_CHECK_FUNCS of libfido2 functions generate wrong results if not using pkg-config
https://bugzilla.mindrot.org/show_bug.cgi?id=3530 Bug ID: 3530 Summary: AC_CHECK_FUNCS of libfido2 functions generate wrong results if not using pkg-config Product: Portable OpenSSH Version: 9.1p1 Hardware: All OS: Linux Status: NEW Severity: normal Priority: P5 Component: Build system Assignee: unassigned-bugs at mindrot.org Reporter: yzhangad at gmail.com When autoconf uses `AC_CHECK_FUNCS` to test the existence of necessary libfido2 functions, it appends `$LIBFIDO2` to `$LIBS`: https://github.com/openssh/openssh-portable/blob/a20b7e999773e6333c8aa9b0a7fa41966e63b037/configure.ac#L3248. In an environment without `pkg-config`, this makes `-lfido2 -lcbor` appear at the end of the linker flags. The problem of this: `libcbor` is not the only dependency of `libfido2`: it also depends on, e.g. `libcrypto`, which is part of OpenSSL, and that can be configured via the `--with-ssl-dir` option. When OpenSSL and `libfido2` are built statically, the existing `configure.ac` makes `-lcrypto` go before `-lfido2`, making the linkage break, thus causing false negative results of `AC_CHECK_FUNCS`. The fix should consist just of replacing `LIBS="$LIBS $LIBFIDO2"` with `LIBS="$LIBFIDO2 $LIBS"`. -- You are receiving this mail because: You are watching the assignee of the bug.
bugzilla-daemon at mindrot.org
2023-Jan-31 22:23 UTC
[Bug 3530] AC_CHECK_FUNCS of libfido2 functions generate wrong results if not using pkg-config
https://bugzilla.mindrot.org/show_bug.cgi?id=3530 Damien Miller <djm at mindrot.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |djm at mindrot.org, | |dtucker at dtucker.net Status|NEW |ASSIGNED Assignee|unassigned-bugs at mindrot.org |djm at mindrot.org Attachment #3654| |ok?(dtucker at dtucker.net) Flags| | --- Comment #1 from Damien Miller <djm at mindrot.org> --- Created attachment 3654 --> https://bugzilla.mindrot.org/attachment.cgi?id=3654&action=edit Implement James' fix -- You are receiving this mail because: You are watching someone on the CC list of the bug. You are watching the assignee of the bug.
bugzilla-daemon at mindrot.org
2023-Jan-31 23:12 UTC
[Bug 3530] AC_CHECK_FUNCS of libfido2 functions generate wrong results if not using pkg-config
https://bugzilla.mindrot.org/show_bug.cgi?id=3530 Darren Tucker <dtucker at dtucker.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #3654|ok?(dtucker at dtucker.net) |ok+ Flags| | -- You are receiving this mail because: You are watching the assignee of the bug. You are watching someone on the CC list of the bug.
bugzilla-daemon at mindrot.org
2023-Feb-01 01:18 UTC
[Bug 3530] AC_CHECK_FUNCS of libfido2 functions generate wrong results if not using pkg-config
https://bugzilla.mindrot.org/show_bug.cgi?id=3530 Damien Miller <djm at mindrot.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |FIXED Blocks| |3480 --- Comment #2 from Damien Miller <djm at mindrot.org> --- Applied and will be in the OpenSSH 9.2 release due shortly. Referenced Bugs: https://bugzilla.mindrot.org/show_bug.cgi?id=3480 [Bug 3480] tracking bug for openssh-9.2 -- You are receiving this mail because: You are watching the assignee of the bug. You are watching someone on the CC list of the bug.
bugzilla-daemon at mindrot.org
2023-Mar-17 02:38 UTC
[Bug 3530] AC_CHECK_FUNCS of libfido2 functions generate wrong results if not using pkg-config
https://bugzilla.mindrot.org/show_bug.cgi?id=3530 Damien Miller <djm at mindrot.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #3 from Damien Miller <djm at mindrot.org> --- OpenSSH 9.3 has been released. Close resolved bugs -- You are receiving this mail because: You are watching someone on the CC list of the bug. You are watching the assignee of the bug.