Syslinux - Jul 2008 - default64 patch?

I stumbled across the following patch and wondered if it wouldn't be a 
good idea to have it included.

http://foldingcd.svn.sourceforge.net/viewvc/*checkout*/foldingcd/trunk/folding_cd/patches/syslinux-3.51-64bit.patch?revision=5

It adds a default64 keyword and detection of a 64bit processor. It could 
be useful for mixed environments.

The patch is against 3.51, but looks like it would port over to a 
current release easily enough. Although I suspect it would be nice to 
add on to it, if default64 isn't defined to fall back to default for 
backwards compatibility.

Apologies if this has been submitted before (also if it wasn't clear, I 
am not the author of the patch. author @ 
http://sourceforge.net/users/nreilly/ )

-A

Andrew Stuart wrote:
> The patch is against 3.51, but looks like it would port over to a 
> current release easily enough.
We have similar ones in Debian (for 3.70)

http://git.debian.net/?p=syslinux.git;a=blob;f=debian/patches/02-64bit-autodetection.dpatch;h=c5b7d22c90943a50afbfc5c4346fbb205a4306ff;hb=debian

and

http://git.debian.net/?p=syslinux.git;a=blob;f=debian/patches/03-64bit-autodetection-menu.dpatch;h=c0a15524f4baaf0ec95ef8195155a743c403c313;hb=debian

-- 
Address:        Daniel Baumann, Burgunderstrasse 3, CH-4562 Biberist
Email:          daniel.baumann at panthera-systems.net
Internet:       http://people.panthera-systems.net/~daniel-baumann/

Daniel Baumann wrote:
> Andrew Stuart wrote:
>> The patch is against 3.51, but looks like it would port over to a 
>> current release easily enough.
> 
> We have similar ones in Debian (for 3.70)
> 
>
http://git.debian.net/?p=syslinux.git;a=blob;f=debian/patches/02-64bit-autodetection.dpatch;h=c5b7d22c90943a50afbfc5c4346fbb205a4306ff;hb=debian
> 
> and
> 
>
http://git.debian.net/?p=syslinux.git;a=blob;f=debian/patches/03-64bit-autodetection-menu.dpatch;h=c0a15524f4baaf0ec95ef8195155a743c403c313;hb=debian
> 
I have rejected this before.

I will not added this or any other hardware detection to the assembly 
code code.  It can be done much more cleanly in a very small com32 module.

	-hpa

H. Peter Anvin wrote:
> 
> I have rejected this before.
> 
> I will not added this or any other hardware detection to the assembly 
> code code.  It can be done much more cleanly in a very small com32 module.
> 
Just threw in such a module (untested) and pushed it out as 
syslinux-3.71-pre13.

: tazenda 153 ; ls -l com32/modules/ifcpu64.c32
-rwxrwxr-x 1 hpa hpa 904 2008-07-16 15:24 com32/modules/ifcpu64.c32*

	-hpa

H. Peter Anvin wrote:
> Just threw in such a module (untested) and pushed it out as 
> syslinux-3.71-pre13.
> 
> : tazenda 153 ; ls -l com32/modules/ifcpu64.c32
> -rwxrwxr-x 1 hpa hpa 904 2008-07-16 15:24 com32/modules/ifcpu64.c32*
I noticed the new com32/include/cpuid.h duplicates some code from
com32/include/sys/cpu.h (cpuid_eax, cpuid_ecx and cpuid_edx). Maybe remove
those three from cpuid.h and include sys/cpu.h?

- Sebastian

H. Peter Anvin wrote:
> H. Peter Anvin wrote:
>> I have rejected this before.
>>
>> I will not added this or any other hardware detection to the assembly 
>> code code.  It can be done much more cleanly in a very small com32
module.
>>
> 
> Just threw in such a module (untested) and pushed it out as 
> syslinux-3.71-pre13.
> 
> : tazenda 153 ; ls -l com32/modules/ifcpu64.c32
> -rwxrwxr-x 1 hpa hpa 904 2008-07-16 15:24 com32/modules/ifcpu64.c32*
> 
> 	-hpa
> 
Thanks, once it propagates I will throw it at some test machines.

-A