Michael S. Tsirkin
2023-Jan-27 10:53 UTC
[PATCH 0/2] Fix expected set_vq_state behavior on vdpa_sim
On Wed, Jan 18, 2023 at 05:43:57PM +0100, Eugenio P?rez wrote:> The use of set_vq_state is to indicate vdpa device the state of a virtqueue. > In the case of split, it means the avail_idx. This is mandatory for use > cases like live migration. > > However, vdpa_sim reset the vq state at vdpasim_queue_ready since it calls > vringh_init_iotlb. > > Also, to starting from an used_idx different than 0 is needed in use cases like > virtual machine migration. Not doing so and letting the caller set an avail > idx different than 0 causes destination device to try to use old buffers that > source driver already recover and are not available anymore. > > This series fixes both problems allowing to migrate to a vdpa_sim_net device.Jason problems you pointed out are all consmetic do you ack the patchset? Or expect another revision?> Eugenio P?rez (2): > vdpa_sim: not reset state in vdpasim_queue_ready > vringh: fetch used_idx from vring at vringh_init_iotlb > > drivers/vdpa/vdpa_sim/vdpa_sim.c | 2 ++ > drivers/vhost/vringh.c | 25 +++++++++++++++++++++++-- > 2 files changed, 25 insertions(+), 2 deletions(-) > > -- > 2.31.1 >
Seemingly Similar Threads
- [PATCH 1/2] vdpa_sim: not reset state in vdpasim_queue_ready
- [PATCH v2] vdpa_sim: set last_used_idx as last_avail_idx in vdpasim_queue_ready
- [PATCH v3 5/8] vdpa_sim: make devices agnostic for work management
- [PATCH v3 8/8] vdpa_sim: add support for user VA
- [PATCH v2 8/8] vdpa_sim: add support for user VA