Michael S. Tsirkin
2023-Jan-27 10:43 UTC
[PATCH -next] vdpa/mlx5: fix check wrong pointer in mlx5_vdpa_add_mac_vlan_rules()
Were you going to do this? On Wed, Jan 04, 2023 at 02:31:52PM +0000, Eli Cohen wrote:> Sure, thanks! > > > -----Original Message----- > > From: Michael S. Tsirkin <mst at redhat.com> > > Sent: Wednesday, 4 January 2023 15:58 > > To: Eli Cohen <elic at nvidia.com> > > Cc: Yang Yingliang <yangyingliang at huawei.com>; virtualization at lists.linux- > > foundation.org; jasowang at redhat.com > > Subject: Re: [PATCH -next] vdpa/mlx5: fix check wrong pointer in > > mlx5_vdpa_add_mac_vlan_rules() > > > > On Wed, Jan 04, 2023 at 11:41:31AM +0000, Eli Cohen wrote: > > > I see these patches were not sent yet. > > > Michael/Yang Yinglliang, isn't it better to send a fixed patch instead of > > sending the original and fix on top of it? > > > > depends on the severity of the fix. in this case it seems to leak > > uninitialized stack data to userspace, so I'd say it's best to > > squash in the fix. > > keep signed-off by of the fixup contributor so they get attribution. > > > > -- > > MST >