I downloaded shorewall 1.2.1 this morning, and now before I can even try it there''s been another version released AND a bugfix? Now that''s what I call rapid development. Jim Hubbard
On Tuesday 08 January 2002 01:55 pm, Jim Hubbard wrote:> I downloaded shorewall 1.2.1 this morning, and now before I can even try it > there''s been another version released AND a bugfix? Now that''s what I call > rapid development.On the first count (1.2.1->1.2.2), you just had bad timeing. On to the second=20 (the bugfix), I''m wearing a brown paper bag over my head this afternoon..=2E -Tom --=20 Tom Eastep \ A Firewall for Linux 2.4.* AIM: tmeastep \ http://www.shorewall.net ICQ: #60745924 \ teastep@shorewall.net -------------------------------------------
Tom Eastep wrote:> On the first count (1.2.1->1.2.2), you just had bad timeing. On to the second > (the bugfix), I''m wearing a brown paper bag over my head this afternoon... > > -TomHey Tom, No need for that paper bag! Your hard work is sure appreciated by all of us who use Shorewall. Keep up the good work!.... :) -- Patrick Benson Stockholm, Sweden
Greetings !
The install script seems to miss updating the shorewall.conf file.
(was looking forward to BLACKLIST)
install.sh:
# Install the config file
#
if [ -f ${PREFIX}/etc/shorewall/shorewall.conf ]; then
backup_file /etc/shorewall/shorewall.conf
else
run_install -o root -g root -m 0744 shorewall.conf
${PREFIX}/etc/shorewall/shorewall.conf
echo -e "\nConfig file installed as
${PREFIX}/etc/shorewall/shorewall.conf"
fi
Shouldn''t it be something like:
# Install the config file
#
if [ -f ${PREFIX}/etc/shorewall/shorewall.conf ]; then
backup_file /etc/shorewall/shorewall.conf
run_install -o root -g root -m 0744 shorewall.conf
${PREFIX}/etc/shorewall/shorewall.conf
echo -e "\nConfig file installed as
${PREFIX}/etc/shorewall/shorewall.conf"
else
run_install -o root -g root -m 0744 shorewall.conf
${PREFIX}/etc/shorewall/shorewall.conf
echo -e "\nConfig file installed as
${PREFIX}/etc/shorewall/shorewall.conf"
fi
If the conf exists back it up then install new one. I dunno I just
copied it in and diff/edit.
--
steve
On Tuesday 08 January 2002 03:37 pm, Steve Ladewig wrote:> Greetings ! > The install script seems to miss updating the shorewall.conf file. > (was looking forward to BLACKLIST) > > install.sh: > # Install the config file > # > if [ -f ${PREFIX}/etc/shorewall/shorewall.conf ]; then > backup_file /etc/shorewall/shorewall.conf > else > run_install -o root -g root -m 0744 shorewall.conf > ${PREFIX}/etc/shorewall/shorewall.conf > echo -e "\nConfig file installed as > ${PREFIX}/etc/shorewall/shorewall.conf" > fi > > Shouldn''t it be something like: > # Install the config file > # > if [ -f ${PREFIX}/etc/shorewall/shorewall.conf ]; then > backup_file /etc/shorewall/shorewall.conf > run_install -o root -g root -m 0744 shorewall.conf > ${PREFIX}/etc/shorewall/shorewall.conf > echo -e "\nConfig file installed as > ${PREFIX}/etc/shorewall/shorewall.conf" > else > run_install -o root -g root -m 0744 shorewall.conf > ${PREFIX}/etc/shorewall/shorewall.conf > echo -e "\nConfig file installed as > ${PREFIX}/etc/shorewall/shorewall.conf" > fi > > If the conf exists back it up then install new one. I dunno I just > copied it in and diff/edit.I never overwrite your existing config files during an upgrade. I assume that=20 when new parameters are added that people will edit their files and add=20 parameters if they need to. I try to pick reasonable defaults so that if you=20 do nothing, new features will work in a reasonable fashion. In the case of=20 blacklisting, if you don''t do anything to your shorewall.conf, you get=20 BLACKLIST_DISPOSITION=3DDROP and BLACKLIST_LOGLEVEL=3D. I personally find those=20 reasonable (since they''re the settings I use ;-) -Tom --=20 Tom Eastep \ A Firewall for Linux 2.4.* AIM: tmeastep \ http://www.shorewall.net ICQ: #60745924 \ teastep@shorewall.net -------------------------------------------
Tom, I echo this. No need for the paper bag. Thanks again for all the hard work that you put into Shorewall. PS. I really like the blacklist feature that you have added. Cheers, Mike -----Original Message----- From: Patrick Benson [mailto:benson@chello.se] Sent: Tuesday, January 08, 2002 5:14 PM To: shorewall-users@shorewall.net Subject: Re: [Shorewall-users] Shorewall Tom Eastep wrote:> On the first count (1.2.1->1.2.2), you just had bad timeing. On to thesecond> (the bugfix), I''m wearing a brown paper bag over my head this afternoon... > > -TomHey Tom, No need for that paper bag! Your hard work is sure appreciated by all of us who use Shorewall. Keep up the good work!.... :) -- Patrick Benson Stockholm, Sweden _______________________________________________ Shorewall-users mailing list Shorewall-users@shorewall.net http://www.shorewall.net/mailman/listinfo/shorewall-users
Hi Tom, On Tue, 8 Jan 2002, Tom Eastep wrote:> On Tuesday 08 January 2002 01:55 pm, Jim Hubbard wrote: > > I downloaded shorewall 1.2.1 this morning, and now before I can even try it > > there''s been another version released AND a bugfix? Now that''s what I call > > rapid development. > > On the first count (1.2.1->1.2.2), you just had bad timeing. On to the second > (the bugfix), I''m wearing a brown paper bag over my head this afternoon...I just gave it a go, seems to work just fine here, thanks for the blacklisting support! Regards, Pieter. -- Pas op de muonen!
At 00:14 09.01.2002 +0100, Patrick Benson wrote:>Tom Eastep wrote: > > > On the first count (1.2.1->1.2.2), you just had bad timeing. On to the > second > > (the bugfix), I''m wearing a brown paper bag over my head this afternoon... > > > > -Tom > >Hey Tom, > >No need for that paper bag! Your hard work is sure appreciated by all of >us who use Shorewall. Keep up the good work!.... :)Yep!!!