openssh bugs - Dec 2021 - [Bug 3376] New: Documentation says C89 compiler required but C99 compiler is actually required

https://bugzilla.mindrot.org/show_bug.cgi?id=3376

            Bug ID: 3376
           Summary: Documentation says C89 compiler required but C99
                    compiler is actually required
           Product: Portable OpenSSH
           Version: 8.8p1
          Hardware: ix86
                OS: Linux
            Status: NEW
          Severity: minor
          Priority: P5
         Component: Documentation
          Assignee: unassigned-bugs at mindrot.org
          Reporter: gregkatz at gmail.com

I'm trying to compile a OpenSSH portable for a system that has a C89
capable compiler, but not a C99 capable compiler, which the INSTALL
file says should work: "A C compiler.  Any C89 or better compiler
should work." However, the configure script checks for C99. Might make
sense to update the INSTALL file.

Thanks for all your hard work on OpenSSH. Truly an amazing piece of
software. I remember when I was skeptical about switching from telnet.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3376

Darren Tucker <dtucker at dtucker.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dtucker at dtucker.net

--- Comment #1 from Darren Tucker <dtucker at dtucker.net> ---
Created attachment 3560
  --> https://bugzilla.mindrot.org/attachment.cgi?id=3560&action=edit
Provide c89-compatible logging functions

AFAIK the only thing we have that's not c89 are the variadic logging
macros, and as indicated by the comment in configure.ac, we had a vague
plan to provide functions that don't need those.

I took a stab at it (it'll lose the ability to show file, line and
function but otherwise should work).

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3376

--- Comment #2 from Gregory Katz <gregkatz at gmail.com> ---
Thanks Darren, and apologies for the delayed response. This patch got
me most of the way to compiling. I also had to move some variable
initializations up in openbsd-compat/sha2.c, but I'm not sure if that's
strictly a C89 limitation, and modify utf8.c (because it was
complaining that CODESET was undefined).

I wasn't able to test the changes to configure.ac--my system was too
old to generate a new configure script, so I just manually disabled the
test in the provided configure script.

At any rate, the ssh client works well which is a small miracle, but
the server segfaults. Not bad, in my opinion.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.