Jason Wang
2021-Oct-13 03:49 UTC
[RFC PATCH v4 11/20] vhost: Route host->guest notification through shadow virtqueue
? 2021/10/1 ??3:05, Eugenio P?rez ??:> This will make qemu aware of the device used buffers, allowing it to > write the guest memory with its contents if needed. > > Since the use of vhost_virtqueue_start can unmasks and discard call > events, vhost_virtqueue_start should be modified in one of these ways: > * Split in two: One of them uses all logic to start a queue with no > side effects for the guest, and another one tha actually assumes that > the guest has just started the device. Vdpa should use just the > former. > * Actually store and check if the guest notifier is masked, and do it > conditionally. > * Left as it is, and duplicate all the logic in vhost-vdpa.Btw, the log looks not clear. I guess this patch goes for method 3. If yes, we need explain it and why. Thanks> > Signed-off-by: Eugenio P?rez<eperezma at redhat.com>