Stefano Garzarella
2022-Jan-13 14:11 UTC
[PATCH] vhost: remove avail_event arg from vhost_update_avail_event()
In vhost_update_avail_event() we never used the `avail_event` argument,
since its introduction in commit 2723feaa8ec6 ("vhost: set log when
updating used flags or avail event").
Let's remove it to clean up the code.
Signed-off-by: Stefano Garzarella <sgarzare at redhat.com>
---
drivers/vhost/vhost.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c
index 59edb5a1ffe2..ee171e663a18 100644
--- a/drivers/vhost/vhost.c
+++ b/drivers/vhost/vhost.c
@@ -1981,7 +1981,7 @@ static int vhost_update_used_flags(struct vhost_virtqueue
*vq)
return 0;
}
-static int vhost_update_avail_event(struct vhost_virtqueue *vq, u16
avail_event)
+static int vhost_update_avail_event(struct vhost_virtqueue *vq)
{
if (vhost_put_avail_event(vq))
return -EFAULT;
@@ -2527,7 +2527,7 @@ bool vhost_enable_notify(struct vhost_dev *dev, struct
vhost_virtqueue *vq)
return false;
}
} else {
- r = vhost_update_avail_event(vq, vq->avail_idx);
+ r = vhost_update_avail_event(vq);
if (r) {
vq_err(vq, "Failed to update avail event index at %p: %d\n",
vhost_avail_event(vq), r);
--
2.31.1
Jason Wang
2022-Jan-14 06:12 UTC
[PATCH] vhost: remove avail_event arg from vhost_update_avail_event()
On Thu, Jan 13, 2022 at 10:11 PM Stefano Garzarella <sgarzare at redhat.com> wrote:> > In vhost_update_avail_event() we never used the `avail_event` argument, > since its introduction in commit 2723feaa8ec6 ("vhost: set log when > updating used flags or avail event"). > > Let's remove it to clean up the code. > > Signed-off-by: Stefano Garzarella <sgarzare at redhat.com>Acked-by: Jason Wang <jasowang at redhat.com>> --- > drivers/vhost/vhost.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c > index 59edb5a1ffe2..ee171e663a18 100644 > --- a/drivers/vhost/vhost.c > +++ b/drivers/vhost/vhost.c > @@ -1981,7 +1981,7 @@ static int vhost_update_used_flags(struct vhost_virtqueue *vq) > return 0; > } > > -static int vhost_update_avail_event(struct vhost_virtqueue *vq, u16 avail_event) > +static int vhost_update_avail_event(struct vhost_virtqueue *vq) > { > if (vhost_put_avail_event(vq)) > return -EFAULT; > @@ -2527,7 +2527,7 @@ bool vhost_enable_notify(struct vhost_dev *dev, struct vhost_virtqueue *vq) > return false; > } > } else { > - r = vhost_update_avail_event(vq, vq->avail_idx); > + r = vhost_update_avail_event(vq); > if (r) { > vq_err(vq, "Failed to update avail event index at %p: %d\n", > vhost_avail_event(vq), r); > -- > 2.31.1 >