Greg KH
2021-Oct-10 05:33 UTC
[PATCH v10 2/3] tty: hvc: pass DMA capable memory to put_chars()
On Sat, Oct 09, 2021 at 11:45:23PM +0800, Xianting Tian wrote:> > ? 2021/10/9 ??7:58, Greg KH ??: > > Did you look at the placement using pahole as to how this structure now > > looks? > > thanks for all your commnts. for this one, do you mean I need to remove the > blank line?? thanks >No, I mean to use the tool 'pahole' to see the structure layout that you just created and determine if it really is the best way to add these new fields, especially as you are adding huge buffers with odd alignment. thanks, greg k-h