Jason Wang
2021-Jul-15 08:03 UTC
[PATCH 1/4] vdpa_sim: Fix return value check for vdpa_alloc_device()
? 2021/7/15 ??3:59, Xie Yongji ??:> The vdpa_alloc_device() returns an error pointer upon > failure, not NULL. To handle the failure correctly, this > replaces NULL check with IS_ERR() check and propagate the > error upwards. > > Fixes: 2c53d0f64c06 ("vdpasim: vDPA device simulator") > Reported-by: Dan Carpenter <dan.carpenter at oracle.com> > Signed-off-by: Xie Yongji <xieyongji at bytedance.com>Acked-by: Jason Wang <jasowang at redhat.com>> --- > drivers/vdpa/vdpa_sim/vdpa_sim.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/vdpa/vdpa_sim/vdpa_sim.c b/drivers/vdpa/vdpa_sim/vdpa_sim.c > index 14e024de5cbf..c621cf7feec0 100644 > --- a/drivers/vdpa/vdpa_sim/vdpa_sim.c > +++ b/drivers/vdpa/vdpa_sim/vdpa_sim.c > @@ -251,8 +251,10 @@ struct vdpasim *vdpasim_create(struct vdpasim_dev_attr *dev_attr) > > vdpasim = vdpa_alloc_device(struct vdpasim, vdpa, NULL, ops, > dev_attr->name); > - if (!vdpasim) > + if (IS_ERR(vdpasim)) { > + ret = PTR_ERR(vdpasim); > goto err_alloc; > + } > > vdpasim->dev_attr = *dev_attr; > INIT_WORK(&vdpasim->work, dev_attr->work_fn);