Jean-Philippe Brucker
2021-Mar-03 17:21 UTC
[PATCH RFC v1 09/15] iommu/virtio: Update table format probing header
On Fri, Jan 15, 2021 at 05:43:36PM +0530, Vivek Gautam wrote:> Add info about asid_bits and additional flags to table format > probing header. > > Signed-off-by: Vivek Gautam <vivek.gautam at arm.com> > Cc: Joerg Roedel <joro at 8bytes.org> > Cc: Will Deacon <will.deacon at arm.com> > Cc: Michael S. Tsirkin <mst at redhat.com> > Cc: Robin Murphy <robin.murphy at arm.com> > Cc: Jean-Philippe Brucker <jean-philippe at linaro.org> > Cc: Eric Auger <eric.auger at redhat.com> > Cc: Alex Williamson <alex.williamson at redhat.com> > Cc: Kevin Tian <kevin.tian at intel.com> > Cc: Jacob Pan <jacob.jun.pan at linux.intel.com> > Cc: Liu Yi L <yi.l.liu at intel.com> > Cc: Lorenzo Pieralisi <lorenzo.pieralisi at arm.com> > Cc: Shameerali Kolothum Thodi <shameerali.kolothum.thodi at huawei.com> > --- > include/uapi/linux/virtio_iommu.h | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/include/uapi/linux/virtio_iommu.h b/include/uapi/linux/virtio_iommu.h > index 43821e33e7af..8a0624bab4b2 100644 > --- a/include/uapi/linux/virtio_iommu.h > +++ b/include/uapi/linux/virtio_iommu.h > @@ -169,7 +169,10 @@ struct virtio_iommu_probe_pasid_size { > struct virtio_iommu_probe_table_format { > struct virtio_iommu_probe_property head; > __le16 format; > - __u8 reserved[2]; > + __le16 asid_bits; > + > + __le32 flags;This struct should only contain the head and format fields. asid and flags should go in a specialized structure - virtio_iommu_probe_pgt_arm64 in the latest spec draft, where I dropped the asid_bits field in favor of an "ASID16" flag. Thanks, Jean