openssh bugs - Sep 2022 - [Bug 3474] New: ssh_config can escape double quotes with a backslash

https://bugzilla.mindrot.org/show_bug.cgi?id=3474

            Bug ID: 3474
           Summary: ssh_config can escape double quotes with a backslash
           Product: Portable OpenSSH
           Version: v9.0p1
          Hardware: Other
                OS: Linux
            Status: NEW
          Severity: enhancement
          Priority: P5
         Component: ssh
          Assignee: unassigned-bugs at mindrot.org
          Reporter: unknowndevqwq at pm.me

Some match exec rules may require more than one pair of double quotes,
but the current ssh_config will simply truncate the first pair and
ignore the backslash-escaped double quotes and other special character
conventions

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3474

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |djm at mindrot.org

--- Comment #1 from Damien Miller <djm at mindrot.org> ---
readconf.c:match_cfg_line() probably needs to be converted from
strdelim() to argv_split() for this to happen.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3474

--- Comment #2 from unknowndevqwq at pm.me ---
(In reply to Damien Miller from comment #1)
> readconf.c:match_cfg_line() probably needs to be converted from
> strdelim() to argv_split() for this to happen.
s/strdelim()/argv_split()/
Like this?

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3474

--- Comment #3 from Damien Miller <djm at mindrot.org> ---
No unfortunately - it's a bit more of a substantial rewrite than that.
strdelim() is an incremental tokeniser whereas argv_split() turns a
string into a vector of arguments in one go.

https://github.com/openssh/openssh-portable/commit/ea9e45c89a is the
commit where we started using it for config parsing if you want to have
a go at this yourself.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3474

--- Comment #4 from unknowndevqwq at pm.me ---
Sorry, I can't do it.

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3474

NIWA Naoya <mine at mine02c4.nagoya> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mine at mine02c4.nagoya

--- Comment #5 from NIWA Naoya <mine at mine02c4.nagoya> ---
I am facing this problem. Specifically, I want to pass the result of
the command execution including spaces to "test" command as a single
string.
This requires passing a string containing double quotes to the shell,
which is not possible with the current version. Miller's patch does
this, but it is not currently implemented. Is there anything I can do
to get this into the main stream?

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3474

--- Comment #6 from NIWA Naoya <mine at mine02c4.nagoya> ---
Excuse me, I forgot to write an important explanation. I'm encountering
this problem with "exec" parameter in "Match" statement.
This
implementation uses "strdelim" and cannot escape double quotes.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3474

--- Comment #7 from Damien Miller <djm at mindrot.org> ---
Created attachment 3758
  --> https://bugzilla.mindrot.org/attachment.cgi?id=3758&action=edit
Make Match keywords in ssh_config and sshd_config use argv rather than
strdelim

This changes the argument splitting of Match to use the argv tokeniser
that is used for the rest of config parsing. Please test.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.