openssh bugs - Oct 2021 - [Bug 3351] New: RSA SHA256 certificates no longer work

https://bugzilla.mindrot.org/show_bug.cgi?id=3351

            Bug ID: 3351
           Summary: RSA SHA256 certificates no longer work
           Product: Portable OpenSSH
           Version: 8.8p1
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5
         Component: ssh
          Assignee: unassigned-bugs at mindrot.org
          Reporter: denisenkom at gmail.com

RSA SHA256 certificate authentication stopped working in 8.8.

It looks like RSA SHA256 certificates are identified as
ssh-rsa-cert-v01 at openssh.com instead of as
rsa-sha2-256-cert-v01 at openssh.com and current allow list does not have
ssh-rsa-cert-v01 at openssh.com on it, resulting in rejection of such
certificates by the client.  The root cause seems to be in
misidentification of SHA256 certificates as sh-rsa-cert-v01 at openssh.com
certificates.

Workaround is to add "PubkeyAcceptedKeyTypes
+ssh-rsa-cert-v01 at openssh.com" into client ssh config, but this
doesn't
seem right, since certificate is actually SHA256 certificate and should
be allowed by default.

Reproduction steps:

create CA key:
ssh-keygen -t rsa-sha2-256 -f ca_key

create user key:
ssh-keygen -t rsa-sha2-256 -f user_key

sign certificate using SHA256 signature:
ssh-keygen -s ca_key -I "test" -z "123" -V -1w:+54w5d -t
rsa-sha2-256
-n user user_key.pub 

copy ca_key.pub to server /etc/ssh/ca_key.pub
Add following line to /etc/sshd_config:
TrustedUserCAKeys /etc/ssh/ca_key.pub

restart sshd: sudo service sshd restart

add test user: sudo useradd user

Back on Client run:
ssh -i user_key user@<server-host>

This fails with: user@<server-host>: Permission denied
(publickey,gssapi-keyex,gssapi-with-mic).

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3351

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |djm at mindrot.org

--- Comment #1 from Damien Miller <djm at mindrot.org> ---
I'm not able to replicate this, either manually or with modifications
to regress/cert-userkey.sh to explicitly test this case (though I think
it was previously anyway).

Could you please attach debug traces from the client and server to this
bug?

Note that RSA SHA256 certificates are always identified as
ssh-rsa-cert-v01 at openssh.com because key type names are actually
somewhat separate to signature algorithm names even though they look
the same. So a ssh-rsa-cert-v01 at openssh.com certificate can happily
make a rsa-sha2-256 signature. (Yes, this is a confusing area of the
protocol).

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3351

--- Comment #2 from denisenkom at gmail.com ---
Created attachment 3549
  --> https://bugzilla.mindrot.org/attachment.cgi?id=3549&action=edit
Client log

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3351

--- Comment #3 from denisenkom at gmail.com ---
Attached client log.

Certificate rejection happens on the client.
In sshconnect2.c this line is executed:

1857:   sent = send_pubkey_test(ssh, id);

Then in send_pubkey_test function this line is executed:

1503:   if ((alg = key_sig_algorithm(ssh, id->key)) == NULL) {

Then in key_sig_algorithm function this line is executed:

1195:   return match_list(sshkey_ssh_name(key),

Here sshkey_ssh_name returns "ssh-rsa-cert-v01 at openssh.com" and it
is
compared against a list which is initialized by KEX_DEFAULT_PK_ALG,
which does not contain "ssh-rsa-cert-v01 at openssh.com".  That check
fails and "no mutual signature supported" error is reported.

I was able to "fix" this problem by adding
"ssh-rsa-cert-v01 at openssh.com," into KEX_DEFAULT_PK_ALG in
myproposal.h

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3351

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |WONTFIX
             Status|NEW                         |RESOLVED
            Version|8.8p1                       |7.4p1

--- Comment #4 from Damien Miller <djm at mindrot.org> ---
The problem here is the server, not the client. OpenSSH 7.4 has a
number of bugs relating to RSA-SHA2 algorithm advertisements.

These are mostly worked around in newer versions for plain keys but we
don't do the same for certificates because the compatibility code would
be pretty ugly. It's better to simply upgrade the server to a less-old
release.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3351

--- Comment #5 from denisenkom at gmail.com ---
You are right, I tested with 8.8 server and it worked.

Our server is currently on 7.4p1 and this is the latest available from
repository.

So this change at least breaks compatibility with 7.4.  Do you know
which oldest version supports 8.8 client?

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3351

--- Comment #6 from Damien Miller <djm at mindrot.org> ---
OpenSSH 7.8 definitely works (just tested it). I think the previous
versions had varying degrees of buginess

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3351

--- Comment #7 from denisenkom at gmail.com ---
Adding my findings about difference between 7.4 and 8.8

On 7.4 when this condition is executed:
        if (ssh == NULL || ssh->kex->server_sig_algs == NULL ||
            (key->type != KEY_RSA && key->type != KEY_RSA_CERT) ||
            (key->type == KEY_RSA_CERT && (ssh->compat &
SSH_BUG_SIGTYPE))) {
                /* Filter base key signature alg against our
configuration */
                return match_list(sshkey_ssh_name(key),
                    options.pubkey_accepted_algos, NULL);
        }

the ssh->compat is equal 0x4000006, which is causing "ssh->compat
&
SSH_BUG_SIGTYPE" to be true, and therefore execution enters that if and
then match_list returns false, causing rejection.


On 8.8 the ssh->compat is equal 0x4000000, therefore if is bypassed.
Then this section:
        oallowed = allowed = xstrdup(options.pubkey_accepted_algos);
        while ((cp = strsep(&allowed, ",")) != NULL) {
                if (sshkey_type_from_name(cp) != key->type)
                        continue;
                tmp = match_list(sshkey_sigalg_by_name(cp),
                    server_sig_algs, NULL);
                if (tmp != NULL)
                        alg = xstrdup(cp);
                free(tmp);
                if (alg != NULL)
                        break;
        }
Which passes.

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3351

--- Comment #8 from Damien Miller <djm at mindrot.org> ---
Most of the fixes were in this commit IIRC:

commit 4ba0d54794814ec0de1ec87987d0c3b89379b436
Author: djm at openbsd.org <djm at openbsd.org>
Date:   Tue Jul 3 11:39:54 2018 +0000

    upstream: Improve strictness and control over RSA-SHA2 signature

    In ssh, when an agent fails to return a RSA-SHA2 signature when
    requested and falls back to RSA-SHA1 instead, retry the signature
to
    ensure that the public key algorithm sent in the SSH_MSG_USERAUTH
    matches the one in the signature itself.

    In sshd, strictly enforce that the public key algorithm sent in the
    SSH_MSG_USERAUTH message matches what appears in the signature.

    Make the sshd_config PubkeyAcceptedKeyTypes and
    HostbasedAcceptedKeyTypes options control accepted signature
algorithms
    (previously they selected supported key types). This allows these
    options to ban RSA-SHA1 in favour of RSA-SHA2.

    Add new signature algorithms "rsa-sha2-256-cert-v01 at
openssh.com"
and
    "rsa-sha2-512-cert-v01 at openssh.com" to force use of RSA-SHA2
signatures
    with certificate keys.

    feedback and ok markus@

    OpenBSD-Commit-ID: c6e9f6d45eed8962ad502d315d7eaef32c419dde

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3351

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #9 from Damien Miller <djm at mindrot.org> ---
closing bugs resolved before openssh-8.9

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3351

mohamedazab224 <mahamedazab at icloud.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #3549|0                           |1
        is obsolete|                            |
                 CC|                            |mahamedazab at icloud.com

--- Comment #10 from mohamedazab224 <mahamedazab at icloud.com> ---
Created attachment 3866
  --> https://bugzilla.mindrot.org/attachment.cgi?id=3866&action=edit
Architectural construction and supply services

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3351

mohamedazab224 <mahamedazab at icloud.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|7.4p1                       |9.5p1

--- Comment #11 from mohamedazab224 <mahamedazab at icloud.com> ---
????? ????? OpenSSH ??? ????? ????? RSA SHA256

? ?????:
?? ????? ????? OpenSSH ??? 9.5p1 ??? ????? ??? ????? ?????? RSA SHA256?
????? ?? ??? ???? ?? ????????? ???????. ??????? ???? ??? ???? ???????
?? ???? ???????? ??????? ?????? ????? ??????? ??? SSH.

? ?????????:

????? ????? OpenSSH ??? 9.5p1
?????? ?? ??? ?????? RSA SHA256
????? ??????? ?????? ??????? ????? ??? ???? ????? ?? ????????
? ????????:
[????? ????? ??? ??????? ?? ??????? ??? ???? ??????]

? ??????? ??????:
???? ?????? ??? ??????? ?????? ??????? ?? ?????? ??????? ???????. ??
??? ???? ?? ???????? ???? ?????? ??? Bugzilla ??? 3351 ????? ?? ??????

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.