openssh bugs - Apr 2021 - [Bug 3297] New: Regression - process_input() when read retuns -1

https://bugzilla.mindrot.org/show_bug.cgi?id=3297

            Bug ID: 3297
           Summary: Regression - process_input() when read retuns -1
           Product: Portable OpenSSH
           Version: 8.5p1
          Hardware: Other
                OS: Windows 10
            Status: NEW
          Severity: enhancement
          Priority: P5
         Component: sshd
          Assignee: unassigned-bugs at mindrot.org
          Reporter: balu.gajjala at gmail.com

In V8.1, when read() returns -1 and if errno is not one of these values
(EINTR , EAGAIN , EWOULDBLOCK) then we call cleanup_exit()

https://github.com/openssh/openssh-portable/blob/fbe37c90602fa2d0d7b5f05868d6886b1e216e65/serverloop.c#L332


In V8.5, when read() retuns -1 and if errno is equal to EWOULDBLOCK
then only we call cleanup_exit()

https://github.com/openssh/openssh-portable/blob/0727dd09eca355e7539cbcb23b148fcee9b21513/serverloop.c#L335


It looks like a typo, line 336 (in V8.5) should be,
 errno == EWOULDBLOCK

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3297

balu <balu.gajjala at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |balu.gajjala at gmail.com

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3297

--- Comment #1 from balu <balu.gajjala at gmail.com> ---
Please note in this case the sshd processes (one SYSTEM sshd process
and another user sshd process) hangs indefinetly.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3297

balu <balu.gajjala at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |major

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3297

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |djm at mindrot.org
         Resolution|---                         |FIXED
             Blocks|                            |3270
             Status|NEW                         |RESOLVED

--- Comment #2 from Damien Miller <djm at mindrot.org> ---
Fixed in 2dc328023f


Referenced Bugs:

https://bugzilla.mindrot.org/show_bug.cgi?id=3270
[Bug 3270] Tracking bug for 8.6 release
-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3297

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #3 from Damien Miller <djm at mindrot.org> ---
closing resolved bugs as of 8.6p1 release

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.