openssh bugs - Apr 2021 - [Bug 3291] New: support process_extended_limits() only if HAVE_GETRLIMIT is set

https://bugzilla.mindrot.org/show_bug.cgi?id=3291

            Bug ID: 3291
           Summary: support process_extended_limits() only if
                    HAVE_GETRLIMIT is set
           Product: Portable OpenSSH
           Version: 8.5p1
          Hardware: Other
                OS: Windows 10
            Status: NEW
          Severity: normal
          Priority: P5
         Component: sftp-server
          Assignee: unassigned-bugs at mindrot.org
          Reporter: balu.gajjala at gmail.com

Not all OS distros support rlimit/slimit so sftp-server should support
process_extended_limits() only when HAVE_GETRLIMIT is defined/set.

https://github.com/openssh/openssh-portable/blob/0727dd09eca355e7539cbcb23b148fcee9b21513/sftp-server.c#L1450

https://github.com/openssh/openssh-portable/blob/0727dd09eca355e7539cbcb23b148fcee9b21513/sftp-server.c#L160

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3291

balu <balu.gajjala at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |balu.gajjala at gmail.com

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3291

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
             Blocks|                            |3270
                 CC|                            |djm at mindrot.org
         Resolution|---                         |FIXED

--- Comment #1 from Damien Miller <djm at mindrot.org> ---
I have wrapped the getlimit() call in HAVE_GETRLIMIT in commit
f283a6c2e, but I don't see any reason to skip offering limits extension
- it does offer additional limits beyond the one based on getrlimit()


Referenced Bugs:

https://bugzilla.mindrot.org/show_bug.cgi?id=3270
[Bug 3270] Tracking bug for 8.6 release
-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3291

--- Comment #2 from balu <balu.gajjala at gmail.com> ---
Thanks for your reply.
I saw your commit f283a6c2e.

one comment, 
ifdef HAVE_GETRLIMIT should be moved before struct rlimit rlim;

After this change, on the machines where the rlimit is not supported,
the nfiles (max-open-handles) will be sent as 0. How will the sftp
client behave when sftp-server sends nfiles as 0?

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3291

--- Comment #3 from Damien Miller <djm at mindrot.org> ---
limits.(In reply to balu from comment #2)
> Thanks for your reply.
> I saw your commit f283a6c2e.
> 
> one comment, 
> ifdef HAVE_GETRLIMIT should be moved before struct rlimit rlim;
done
> After this change, on the machines where the rlimit is not
> supported, the nfiles (max-open-handles) will be sent as 0. How will
> the sftp client behave when sftp-server sends nfiles as 0?
Per PROTOCOL:

If the server doesn't enforce a specific limit, then the field may be
set to 0.  This implies the server relies on the OS to enforce limits
(e.g. available memory or file handles), and such limits might be
dynamic.  The client SHOULD take care to not try to exceed reasonable
limits.

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3291

--- Comment #4 from balu <balu.gajjala at gmail.com> ---
Thank you for fixing it in no time.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3291

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #5 from Damien Miller <djm at mindrot.org> ---
closing resolved bugs as of 8.6p1 release

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3291

--- Comment #6 from Damien Miller <djm at mindrot.org> ---
closing resolved bugs as of 8.6p1 release

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.