Mohammed Rafi K C
2014-Nov-26 13:19 UTC
[Gluster-users] Need suggestion to change out put of volume status command
Hi All, We are planning to change the volume status command to show RDMA port for tcp,rdma volumes. We have four output designs in mind , those are, 1)Modify Port column as TCP,RDMA Ports Eg: Status of volume: xcube Gluster process TCP,RDMA Port Online Pid -------------------------------------------------------------------------------- Brick 192.168.44.108:/home/brick 49157,49158 Y 6030 NFS Server on localhost 2049 Y 6532 Self-heal Daemon on localhost N/A N 6234 2)Change entry in port as TCP-XXXXX,RDMA-XXXXX Eg: Status of volume: xcube Gluster process Port Online Pid --------------------------------------------------------------------------------- Brick 192.168.44.108:/home/brick TCP-49157,RDMA-49158 Y 6030 NFS Server on localhost TCP-2049 Y 6532 Self-heal Daemon on localhost N/A N 6234 3)Instead of column port add two other port as TCP Port and RDMA Port Eg: Status of volume: xcube Gluster process TCP Port RDMA Port Online Pid ------------------------------------------------------------------------------- Brick 192.168.44.108:/home/brick 49157 49158 Y 6030 NFS Server on localhost 2049 Y 6532 Self-heal Daemon on localhost N/A N 6234 4) Make an extra row appending ".rdma" with brick name for rdma port Eg: Status of volume: xcube Gluster process Port Online Pid ------------------------------------------------------------------------ Brick 192.168.44.108:/home/brick 49157 Y 6030 Brick 192.168.44.108:/home/brick.rdma 49157 Y 6030 NFS Server on localhost 2049 Y 6532 Self-heal Daemon on localhost N/A N 6234 Please give your comments regarding this designs, or if you have better idea in mind , feel free to share it. Best Regards Rafi KC
Volnei Puttini
2014-Nov-26 13:28 UTC
[Gluster-users] Need suggestion to change out put of volume status command
Hi, Assuming that all the odds to show the ports aren't directly related to the format in which it is shown to the user. I would choose two models, as follows: The 3 and 2 or both. Cheers! On 26-11-2014 11:19, Mohammed Rafi K C wrote:> > Hi All, > > We are planning to change the volume status command to show RDMA port for > tcp,rdma volumes. We have four output designs in mind , those are, > > 1)Modify Port column as TCP,RDMA Ports > Eg: > > Status of volume: xcube > Gluster process TCP,RDMA Port Online Pid > -------------------------------------------------------------------------------- > Brick 192.168.44.108:/home/brick 49157,49158 Y 6030 > NFS Server on localhost 2049 Y 6532 > Self-heal Daemon on localhost N/A N 6234 > > 2)Change entry in port as TCP-XXXXX,RDMA-XXXXX > > Eg: > > > Status of volume: xcube > Gluster process Port Online Pid > --------------------------------------------------------------------------------- > Brick 192.168.44.108:/home/brick TCP-49157,RDMA-49158 Y 6030 > NFS Server on localhost TCP-2049 Y 6532 > Self-heal Daemon on localhost N/A N 6234 > > 3)Instead of column port add two other port as TCP Port and RDMA Port > > Eg: > > > Status of volume: xcube > Gluster process TCP Port RDMA Port Online Pid > ------------------------------------------------------------------------------- > Brick 192.168.44.108:/home/brick 49157 49158 Y 6030 > NFS Server on localhost 2049 Y 6532 > Self-heal Daemon on localhost N/A N 6234 > > 4) Make an extra row appending ".rdma" with brick name for rdma port > > Eg: > > > Status of volume: xcube > Gluster process Port Online Pid > ------------------------------------------------------------------------ > Brick 192.168.44.108:/home/brick 49157 Y 6030 > Brick 192.168.44.108:/home/brick.rdma 49157 Y 6030 > NFS Server on localhost 2049 Y 6532 > Self-heal Daemon on localhost N/A N 6234 > > Please give your comments regarding this designs, or if you have better > idea in mind , feel free to share it. > > Best Regards > Rafi KC > > > > _______________________________________________ > Gluster-users mailing list > Gluster-users at gluster.org > http://supercolony.gluster.org/mailman/listinfo/gluster-users
JF Le Fillâtre
2014-Nov-26 13:41 UTC
[Gluster-users] Need suggestion to change out put of volume status command
Hello Rafi, For clarity and ease of fast visual identification, I would prefer #3. It would be even better to put a dash or something in the RDMA port column when RDMA is not used so that each line can be parsed easily with a relatively regular number of fields: Status of volume: xcube Gluster process TCP Port RDMA Port Online Pid ------------------------------------------------------------------------------- Brick 192.168.44.108:/home/brick 49157 49158 Y 6030 NFS Server on localhost 2049 - Y 6532 Self-heal Daemon on localhost N/A N/A N 6234 The only real downside is that any existing script that parses that output would have to be rewritten to offset the "Online" and "Pid" fields. #1 makes parsing the output a little bit more complicated as it requires sub-parsing of the TCP,RDMA string. It's relatively easy to pick up the visual information though. #2 is just too busy, too much information encoded in the value fields. Not easy on the eyes, and more annoying to parse than #1. #4 is the one I like the least, for two reasons: - currently as in options 1 to 3, each item of the first column is a separate entity. With #4 you have the same brick twice, which requires more sub-parsing or matching to discriminate. - The access mode is encoded irregularly at the end of the name (.rdma but not .tcp). I believe that the access mode is not part of the name but is a property of the brick, and therefore should not be encoded in the name field. Note that when I talk about difficulties of parsing, nothing in the four options you presented is impossible to parse. But #3 is the easiest with a trivial one-liner. Thanks a lot for asking for our input! :) JF PS: "PID" is an acronym, can you spell it all caps please? On 26/11/14 14:19, Mohammed Rafi K C wrote:> > > Hi All, > > We are planning to change the volume status command to show RDMA port for > tcp,rdma volumes. We have four output designs in mind , those are, > > 1)Modify Port column as TCP,RDMA Ports > Eg: > > Status of volume: xcube > Gluster process TCP,RDMA Port Online Pid > -------------------------------------------------------------------------------- > Brick 192.168.44.108:/home/brick 49157,49158 Y 6030 > NFS Server on localhost 2049 Y 6532 > Self-heal Daemon on localhost N/A N 6234 > > 2)Change entry in port as TCP-XXXXX,RDMA-XXXXX > > Eg: > > > Status of volume: xcube > Gluster process Port Online Pid > --------------------------------------------------------------------------------- > Brick 192.168.44.108:/home/brick TCP-49157,RDMA-49158 Y 6030 > NFS Server on localhost TCP-2049 Y 6532 > Self-heal Daemon on localhost N/A N 6234 > > 3)Instead of column port add two other port as TCP Port and RDMA Port > > Eg: > > > Status of volume: xcube > Gluster process TCP Port RDMA Port Online Pid > ------------------------------------------------------------------------------- > Brick 192.168.44.108:/home/brick 49157 49158 Y 6030 > NFS Server on localhost 2049 Y 6532 > Self-heal Daemon on localhost N/A N 6234 > > 4) Make an extra row appending ".rdma" with brick name for rdma port > > Eg: > > > Status of volume: xcube > Gluster process Port Online Pid > ------------------------------------------------------------------------ > Brick 192.168.44.108:/home/brick 49157 Y 6030 > Brick 192.168.44.108:/home/brick.rdma 49157 Y 6030 > NFS Server on localhost 2049 Y 6532 > Self-heal Daemon on localhost N/A N 6234 > > Please give your comments regarding this designs, or if you have better > idea in mind , feel free to share it. > > Best Regards > Rafi KC > > > > _______________________________________________ > Gluster-users mailing list > Gluster-users at gluster.org > http://supercolony.gluster.org/mailman/listinfo/gluster-users >
Atin Mukherjee
2014-Nov-26 14:57 UTC
[Gluster-users] [Gluster-devel] Need suggestion to change out put of volume status command
I would vote for 2nd one. ~Atin On 11/26/2014 06:49 PM, Mohammed Rafi K C wrote:> > > Hi All, > > We are planning to change the volume status command to show RDMA port for > tcp,rdma volumes. We have four output designs in mind , those are, > > 1)Modify Port column as TCP,RDMA Ports > Eg: > > Status of volume: xcube > Gluster process TCP,RDMA Port Online Pid > -------------------------------------------------------------------------------- > Brick 192.168.44.108:/home/brick 49157,49158 Y 6030 > NFS Server on localhost 2049 Y 6532 > Self-heal Daemon on localhost N/A N 6234 > > 2)Change entry in port as TCP-XXXXX,RDMA-XXXXX > > Eg: > > > Status of volume: xcube > Gluster process Port Online Pid > --------------------------------------------------------------------------------- > Brick 192.168.44.108:/home/brick TCP-49157,RDMA-49158 Y 6030 > NFS Server on localhost TCP-2049 Y 6532 > Self-heal Daemon on localhost N/A N 6234 > > 3)Instead of column port add two other port as TCP Port and RDMA Port > > Eg: > > > Status of volume: xcube > Gluster process TCP Port RDMA Port Online Pid > ------------------------------------------------------------------------------- > Brick 192.168.44.108:/home/brick 49157 49158 Y 6030 > NFS Server on localhost 2049 Y 6532 > Self-heal Daemon on localhost N/A N 6234 > > 4) Make an extra row appending ".rdma" with brick name for rdma port > > Eg: > > > Status of volume: xcube > Gluster process Port Online Pid > ------------------------------------------------------------------------ > Brick 192.168.44.108:/home/brick 49157 Y 6030 > Brick 192.168.44.108:/home/brick.rdma 49157 Y 6030 > NFS Server on localhost 2049 Y 6532 > Self-heal Daemon on localhost N/A N 6234 > > Please give your comments regarding this designs, or if you have better > idea in mind , feel free to share it. > > Best Regards > Rafi KC > > > > _______________________________________________ > Gluster-devel mailing list > Gluster-devel at gluster.org > http://supercolony.gluster.org/mailman/listinfo/gluster-devel >
Kanagaraj
2014-Nov-27 04:30 UTC
[Gluster-users] Need suggestion to change out put of volume status command
Do we have corresponding changes in --xml output? If we are removing any existing elements, the management systems will break. Thanks, Kanagaraj On 11/26/2014 06:49 PM, Mohammed Rafi K C wrote:> > Hi All, > > We are planning to change the volume status command to show RDMA port for > tcp,rdma volumes. We have four output designs in mind , those are, > > 1)Modify Port column as TCP,RDMA Ports > Eg: > > Status of volume: xcube > Gluster process TCP,RDMA Port Online Pid > -------------------------------------------------------------------------------- > Brick 192.168.44.108:/home/brick 49157,49158 Y 6030 > NFS Server on localhost 2049 Y 6532 > Self-heal Daemon on localhost N/A N 6234 > > 2)Change entry in port as TCP-XXXXX,RDMA-XXXXX > > Eg: > > > Status of volume: xcube > Gluster process Port Online Pid > --------------------------------------------------------------------------------- > Brick 192.168.44.108:/home/brick TCP-49157,RDMA-49158 Y 6030 > NFS Server on localhost TCP-2049 Y 6532 > Self-heal Daemon on localhost N/A N 6234 > > 3)Instead of column port add two other port as TCP Port and RDMA Port > > Eg: > > > Status of volume: xcube > Gluster process TCP Port RDMA Port Online Pid > ------------------------------------------------------------------------------- > Brick 192.168.44.108:/home/brick 49157 49158 Y 6030 > NFS Server on localhost 2049 Y 6532 > Self-heal Daemon on localhost N/A N 6234 > > 4) Make an extra row appending ".rdma" with brick name for rdma port > > Eg: > > > Status of volume: xcube > Gluster process Port Online Pid > ------------------------------------------------------------------------ > Brick 192.168.44.108:/home/brick 49157 Y 6030 > Brick 192.168.44.108:/home/brick.rdma 49157 Y 6030 > NFS Server on localhost 2049 Y 6532 > Self-heal Daemon on localhost N/A N 6234 > > Please give your comments regarding this designs, or if you have better > idea in mind , feel free to share it. > > Best Regards > Rafi KC > > > > _______________________________________________ > Gluster-users mailing list > Gluster-users at gluster.org > http://supercolony.gluster.org/mailman/listinfo/gluster-users
Jiffin Tony Thottan
2014-Nov-27 06:15 UTC
[Gluster-users] [Gluster-devel] Need suggestion to change out put of volume status command
On 26/11/14 18:49, Mohammed Rafi K C wrote:> Hi All, > > We are planning to change the volume status command to show RDMA port for > tcp,rdma volumes. We have four output designs in mind , those are, > > 1)Modify Port column as TCP,RDMA Ports > Eg: > > Status of volume: xcube > Gluster process TCP,RDMA Port Online Pid > -------------------------------------------------------------------------------- > Brick 192.168.44.108:/home/brick 49157,49158 Y 6030 > NFS Server on localhost 2049 Y 6532 > Self-heal Daemon on localhost N/A N 6234 > 2)Change entry in port as TCP-XXXXX,RDMA-XXXXX > > Eg: > > > Status of volume: xcube > Gluster process Port Online Pid > --------------------------------------------------------------------------------- > Brick 192.168.44.108:/home/brick TCP-49157,RDMA-49158 Y 6030 > NFS Server on localhost TCP-2049 Y 6532 > Self-heal Daemon on localhost N/A N 6234If it is tcp only volume or rdma only volume, it will show "49157,0" for the first one and "TCP-49157 , RDMA-0" for the second or vice-versa , which is not an optimal, it is better to show only available ports for that volume in the `port column`.> 3)Instead of column port add two other port as TCP Port and RDMA Port > > Eg: > > > Status of volume: xcube > Gluster process TCP Port RDMA Port Online Pid > ------------------------------------------------------------------------------- > Brick 192.168.44.108:/home/brick 49157 49158 Y 6030 > NFS Server on localhost 2049 Y 6532 > Self-heal Daemon on localhost N/A N 6234From the user point of this gives better understanding of the rdma port.Although it may effect current test scripts which parse the volume status command> 4) Make an extra row appending ".rdma" with brick name for rdma port > > Eg: > > > Status of volume: xcube > Gluster process Port Online Pid > ------------------------------------------------------------------------ > Brick 192.168.44.108:/home/brick 49157 Y 6030 > Brick 192.168.44.108:/home/brick.rdma 49157 Y 6030 > NFS Server on localhost 2049 Y 6532 > Self-heal Daemon on localhost N/A N 6234May be ,it looks like weird one showing two brick process with same pid.But this change is only for tcp,rdma volumes, in other cases it will continue with existing volume status command. So it won't effect any current test scripts> Please give your comments regarding this designs, or if you have better > idea in mind , feel free to share it. > > Best Regards > Rafi KC > > > > _______________________________________________ > Gluster-devel mailing list > Gluster-devel at gluster.org > http://supercolony.gluster.org/mailman/listinfo/gluster-devel