Linux Ethernet Bridging - Jun 2016 - [Bridge] [PATCH net] net: bridge: fix vlan stats continue counter

I made a dumb off-by-one mistake when I added the vlan stats counter
dumping code. The increment should happen before the check, not after
otherwise we miss one entry when we continue dumping.

Fixes: a60c090361ea ("bridge: netlink: export per-vlan stats")
Signed-off-by: Nikolay Aleksandrov <nikolay at cumulusnetworks.com>
---
 net/bridge/br_netlink.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/bridge/br_netlink.c b/net/bridge/br_netlink.c
index a5343c7232bf..85e89f693589 100644
--- a/net/bridge/br_netlink.c
+++ b/net/bridge/br_netlink.c
@@ -1273,7 +1273,7 @@ static int br_fill_linkxstats(struct sk_buff *skb, const
struct net_device *dev,
 		struct bridge_vlan_xstats vxi;
 		struct br_vlan_stats stats;
 
-		if (vl_idx++ < *prividx)
+		if (++vl_idx < *prividx)
 			continue;
 		memset(&vxi, 0, sizeof(vxi));
 		vxi.vid = v->vid;
-- 
2.1.4

From: Nikolay Aleksandrov <nikolay at cumulusnetworks.com>
Date: Mon, 27 Jun 2016 18:34:42 +0200
> I made a dumb off-by-one mistake when I added the vlan stats counter
> dumping code. The increment should happen before the check, not after
> otherwise we miss one entry when we continue dumping.
> 
> Fixes: a60c090361ea ("bridge: netlink: export per-vlan stats")
> Signed-off-by: Nikolay Aleksandrov <nikolay at cumulusnetworks.com>
Applied.