Al Viro
2019-Jun-26 04:02 UTC
[Ocfs2-devel] [PATCH 1/5] vfs: create a generic checking and prep function for FS_IOC_SETFLAGS
On Tue, Jun 25, 2019 at 07:32:10PM -0700, Darrick J. Wong wrote:> From: Darrick J. Wong <darrick.wong at oracle.com> > > Create a generic function to check incoming FS_IOC_SETFLAGS flag values > and later prepare the inode for updates so that we can standardize the > implementations that follow ext4's flag values.Change in efivarfs behaviour deserves a note. I'm not saying it's wrong, but behaviour is changed there - no-op FS_IOC_SETFLAGS used to fail without CAP_LINUX_IMMUTABLE...
Darrick J. Wong
2019-Jun-26 15:30 UTC
[Ocfs2-devel] [PATCH 1/5] vfs: create a generic checking and prep function for FS_IOC_SETFLAGS
On Wed, Jun 26, 2019 at 05:02:02AM +0100, Al Viro wrote:> On Tue, Jun 25, 2019 at 07:32:10PM -0700, Darrick J. Wong wrote: > > From: Darrick J. Wong <darrick.wong at oracle.com> > > > > Create a generic function to check incoming FS_IOC_SETFLAGS flag values > > and later prepare the inode for updates so that we can standardize the > > implementations that follow ext4's flag values. > > Change in efivarfs behaviour deserves a note. I'm not saying it's wrong, > but behaviour is changed there - no-op FS_IOC_SETFLAGS used to fail > without CAP_LINUX_IMMUTABLE...Ok, will do. FWIW I wondered about fixing the orangefs usage too (using an unsigned long uval to hold the contents of an unsigned int coming from userspace) but ... that's their decision. --D