piaojun
2018-Jan-11 08:13 UTC
[Ocfs2-devel] [PATCH] ocfs2/xattr: assign errno to 'ret' in ocfs2_calc_xattr_init()
We need catch the errno returned by ocfs2_xattr_get_nolock() and assign
it to 'ret' for printing and noticing upper callers.
Signed-off-by: Jun Piao <piaojun at huawei.com>
Reviewed-by: Alex Chen <alex.chen at huawei.com>
Reviewed-by: Yiwen Jiang <jiangyiwen at huawei.com>
---
fs/ocfs2/xattr.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/fs/ocfs2/xattr.c b/fs/ocfs2/xattr.c
index 5fdf269..439f567 100644
--- a/fs/ocfs2/xattr.c
+++ b/fs/ocfs2/xattr.c
@@ -646,6 +646,7 @@ int ocfs2_calc_xattr_init(struct inode *dir,
if (S_ISDIR(mode))
a_size <<= 1;
} else if (acl_len != 0 && acl_len != -ENODATA) {
+ ret = acl_len;
mlog_errno(ret);
return ret;
}
--
Gang He
2018-Jan-11 08:40 UTC
[Ocfs2-devel] [PATCH] ocfs2/xattr: assign errno to 'ret' in ocfs2_calc_xattr_init()
Looks good.>>> > We need catch the errno returned by ocfs2_xattr_get_nolock() and assign > it to 'ret' for printing and noticing upper callers. > > Signed-off-by: Jun Piao <piaojun at huawei.com> > Reviewed-by: Alex Chen <alex.chen at huawei.com> > Reviewed-by: Yiwen Jiang <jiangyiwen at huawei.com>Reviewed-by: Gang He <ghe at suse.com>> --- > fs/ocfs2/xattr.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/fs/ocfs2/xattr.c b/fs/ocfs2/xattr.c > index 5fdf269..439f567 100644 > --- a/fs/ocfs2/xattr.c > +++ b/fs/ocfs2/xattr.c > @@ -646,6 +646,7 @@ int ocfs2_calc_xattr_init(struct inode *dir, > if (S_ISDIR(mode)) > a_size <<= 1; > } else if (acl_len != 0 && acl_len != -ENODATA) { > + ret = acl_len; > mlog_errno(ret); > return ret; > } > -- > > _______________________________________________ > Ocfs2-devel mailing list > Ocfs2-devel at oss.oracle.com > https://oss.oracle.com/mailman/listinfo/ocfs2-devel
Changwei Ge
2018-Jan-11 10:10 UTC
[Ocfs2-devel] [PATCH] ocfs2/xattr: assign errno to 'ret' in ocfs2_calc_xattr_init()
Acked-by: Changwei Ge <ge.changwei at h3c.com> On 2018/1/11 16:14, piaojun wrote:> We need catch the errno returned by ocfs2_xattr_get_nolock() and assign > it to 'ret' for printing and noticing upper callers. > > Signed-off-by: Jun Piao <piaojun at huawei.com> > Reviewed-by: Alex Chen <alex.chen at huawei.com> > Reviewed-by: Yiwen Jiang <jiangyiwen at huawei.com> > --- > fs/ocfs2/xattr.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/fs/ocfs2/xattr.c b/fs/ocfs2/xattr.c > index 5fdf269..439f567 100644 > --- a/fs/ocfs2/xattr.c > +++ b/fs/ocfs2/xattr.c > @@ -646,6 +646,7 @@ int ocfs2_calc_xattr_init(struct inode *dir, > if (S_ISDIR(mode)) > a_size <<= 1; > } else if (acl_len != 0 && acl_len != -ENODATA) { > + ret = acl_len; > mlog_errno(ret); > return ret; > } >