Jia Guo
2018-Apr-21 11:41 UTC
[Ocfs2-devel] [PATCH] ocfs2: clean up redundant function declarations
The function ocfs2_extend_allocation has been deleted, clean up its declaration. Fixes: 964f14a0d350 ("ocfs2: clean up some dead code") Signed-off-by: Jia Guo <guojia12 at huawei.com> Reviewed-by: Jun Piao <piaojun at huawei.com> --- fs/ocfs2/file.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/fs/ocfs2/file.h b/fs/ocfs2/file.h index 1fdc983..7eb7f03 100644 --- a/fs/ocfs2/file.h +++ b/fs/ocfs2/file.h @@ -65,8 +65,6 @@ int ocfs2_extend_no_holes(struct inode *inode, struct buffer_head *di_bh, u64 new_i_size, u64 zero_to); int ocfs2_zero_extend(struct inode *inode, struct buffer_head *di_bh, loff_t zero_to); -int ocfs2_extend_allocation(struct inode *inode, u32 logical_start, - u32 clusters_to_add, int mark_unwritten); int ocfs2_setattr(struct dentry *dentry, struct iattr *attr); int ocfs2_getattr(const struct path *path, struct kstat *stat, u32 request_mask, unsigned int flags); --
Gang He
2018-Apr-23 02:36 UTC
[Ocfs2-devel] [PATCH] ocfs2: clean up redundant function declarations
Reviewed-by: Gang He <ghe at suse.com> Thanks Gang>>> > The function ocfs2_extend_allocation has been deleted, clean up its > declaration. > > Fixes: 964f14a0d350 ("ocfs2: clean up some dead code") > > Signed-off-by: Jia Guo <guojia12 at huawei.com> > Reviewed-by: Jun Piao <piaojun at huawei.com> > --- > fs/ocfs2/file.h | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/fs/ocfs2/file.h b/fs/ocfs2/file.h > index 1fdc983..7eb7f03 100644 > --- a/fs/ocfs2/file.h > +++ b/fs/ocfs2/file.h > @@ -65,8 +65,6 @@ int ocfs2_extend_no_holes(struct inode *inode, struct > buffer_head *di_bh, > u64 new_i_size, u64 zero_to); > int ocfs2_zero_extend(struct inode *inode, struct buffer_head *di_bh, > loff_t zero_to); > -int ocfs2_extend_allocation(struct inode *inode, u32 logical_start, > - u32 clusters_to_add, int mark_unwritten); > int ocfs2_setattr(struct dentry *dentry, struct iattr *attr); > int ocfs2_getattr(const struct path *path, struct kstat *stat, > u32 request_mask, unsigned int flags); > -- > > > _______________________________________________ > Ocfs2-devel mailing list > Ocfs2-devel at oss.oracle.com > https://oss.oracle.com/mailman/listinfo/ocfs2-devel
Joseph Qi
2018-Apr-23 10:51 UTC
[Ocfs2-devel] [PATCH] ocfs2: clean up redundant function declarations
On 18/4/21 19:41, Jia Guo wrote:> The function ocfs2_extend_allocation has been deleted, clean up its > declaration. >I suggest we also change the static function name from __ocfs2_extend_allocation() to ocfs2_extend_allocation() to be consistent with the corresponding trace events as well as comments for ocfs2_lock_allocators(). Thanks, Joseph> Fixes: 964f14a0d350 ("ocfs2: clean up some dead code") > > Signed-off-by: Jia Guo <guojia12 at huawei.com> > Reviewed-by: Jun Piao <piaojun at huawei.com>> --- > fs/ocfs2/file.h | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/fs/ocfs2/file.h b/fs/ocfs2/file.h > index 1fdc983..7eb7f03 100644 > --- a/fs/ocfs2/file.h > +++ b/fs/ocfs2/file.h > @@ -65,8 +65,6 @@ int ocfs2_extend_no_holes(struct inode *inode, struct buffer_head *di_bh, > u64 new_i_size, u64 zero_to); > int ocfs2_zero_extend(struct inode *inode, struct buffer_head *di_bh, > loff_t zero_to); > -int ocfs2_extend_allocation(struct inode *inode, u32 logical_start, > - u32 clusters_to_add, int mark_unwritten); > int ocfs2_setattr(struct dentry *dentry, struct iattr *attr); > int ocfs2_getattr(const struct path *path, struct kstat *stat, > u32 request_mask, unsigned int flags); >