Changwei Ge
2017-Dec-05 05:47 UTC
[Ocfs2-devel] [PATCH] ocfs2/cluster: neaten a member of o2net_msg_handler
It's odd that o2net_msg_handler::nh_func_data is declared as type
o2net_msg_handler_func*.
So neaten it.
Signed-off-by: Changwei Ge <ge.changwei at h3c.com>
---
fs/ocfs2/cluster/tcp_internal.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/ocfs2/cluster/tcp_internal.h
b/fs/ocfs2/cluster/tcp_internal.h
index b95e7df5b76a..0276f7f8d5e6 100644
--- a/fs/ocfs2/cluster/tcp_internal.h
+++ b/fs/ocfs2/cluster/tcp_internal.h
@@ -196,7 +196,7 @@ struct o2net_msg_handler {
u32 nh_msg_type;
u32 nh_key;
o2net_msg_handler_func *nh_func;
- o2net_msg_handler_func *nh_func_data;
+ void *nh_func_data;
o2net_post_msg_handler_func
*nh_post_func;
struct kref nh_kref;
--
2.11.0
alex chen
2017-Dec-05 07:58 UTC
[Ocfs2-devel] [PATCH] ocfs2/cluster: neaten a member of o2net_msg_handler
Hi Changwei, Thank you for your patch. On 2017/12/5 13:47, Changwei Ge wrote:> It's odd that o2net_msg_handler::nh_func_data is declared as type > o2net_msg_handler_func*. > So neaten it. > > Signed-off-by: Changwei Ge <ge.changwei at h3c.com>Reviewed-by: Alex Chen <alex.chen at huawei.com>> --- > fs/ocfs2/cluster/tcp_internal.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/ocfs2/cluster/tcp_internal.h > b/fs/ocfs2/cluster/tcp_internal.h > index b95e7df5b76a..0276f7f8d5e6 100644 > --- a/fs/ocfs2/cluster/tcp_internal.h > +++ b/fs/ocfs2/cluster/tcp_internal.h > @@ -196,7 +196,7 @@ struct o2net_msg_handler { > u32 nh_msg_type; > u32 nh_key; > o2net_msg_handler_func *nh_func; > - o2net_msg_handler_func *nh_func_data; > + void *nh_func_data; > o2net_post_msg_handler_func > *nh_post_func; > struct kref nh_kref; >
Joseph Qi
2017-Dec-05 08:20 UTC
[Ocfs2-devel] [PATCH] ocfs2/cluster: neaten a member of o2net_msg_handler
On 17/12/5 13:47, Changwei Ge wrote:> It's odd that o2net_msg_handler::nh_func_data is declared as type > o2net_msg_handler_func*. > So neaten it. > > Signed-off-by: Changwei Ge <ge.changwei at h3c.com>Reviewed-by: Joseph Qi <jiangqi903 at gmail.com>> --- > fs/ocfs2/cluster/tcp_internal.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/ocfs2/cluster/tcp_internal.h > b/fs/ocfs2/cluster/tcp_internal.h > index b95e7df5b76a..0276f7f8d5e6 100644 > --- a/fs/ocfs2/cluster/tcp_internal.h > +++ b/fs/ocfs2/cluster/tcp_internal.h > @@ -196,7 +196,7 @@ struct o2net_msg_handler { > u32 nh_msg_type; > u32 nh_key; > o2net_msg_handler_func *nh_func; > - o2net_msg_handler_func *nh_func_data; > + void *nh_func_data; > o2net_post_msg_handler_func > *nh_post_func; > struct kref nh_kref; >