Joseph Qi
2016-Jun-16 02:49 UTC
[Ocfs2-devel] [PATCH] ocfs2: cleanup unneeded goto in ocfs2_create_new_inode_locks
The last goto is unneeded, so remove it. Signed-off-by: Joseph Qi <joseph.qi at huawei.com> --- fs/ocfs2/dlmglue.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/fs/ocfs2/dlmglue.c b/fs/ocfs2/dlmglue.c index 474e57f..1cfa1b6bf 100644 --- a/fs/ocfs2/dlmglue.c +++ b/fs/ocfs2/dlmglue.c @@ -1664,10 +1664,8 @@ int ocfs2_create_new_inode_locks(struct inode *inode) } ret = ocfs2_create_new_lock(osb, &OCFS2_I(inode)->ip_open_lockres, 0, 0); - if (ret) { + if (ret) mlog_errno(ret); - goto bail; - } bail: return ret; -- 1.8.4.3
Mark Fasheh
2016-Jun-16 07:03 UTC
[Ocfs2-devel] [PATCH] ocfs2: cleanup unneeded goto in ocfs2_create_new_inode_locks
On Thu, Jun 16, 2016 at 10:49:55AM +0800, Joseph Qi wrote:> The last goto is unneeded, so remove it. > > Signed-off-by: Joseph Qi <joseph.qi at huawei.com>Reviewed-by: Mark Fasheh <mfasheh at suse.de> -- Mark Fasheh