llvm dev - Dec 2021 - How to submit a series of patches in a single review

Hi all,


I'm new for community contribution and I wonder is there a way to submit
patch series in a single review?
For example I have 2 patches: A and B. B depends on A. How can I submit them
together?
1. The Web interface
(https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface)
seems doesn't allow uploading multiple patches.
2. I also tried the command line tool arc
(https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-command-line)
by invoking `arc diff HEAD~` on each commit.
    But these produce 2 seperate reviews and lose dependency.


Any advice?


Best regards,
Shaka
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20211210/36178131/attachment.html>

It's not automated, but what I do is upload them all then go to "Edit
related revisions" on the review page and link them together that way.
Then you should see a "Stack" in the "Revision contents"
section.
(e.g. https://reviews.llvm.org/D107140)

On Fri, 10 Dec 2021 at 11:28, shaka via llvm-dev
<llvm-dev at lists.llvm.org> wrote:
>
> Hi all,
>
> I'm new for community contribution and I wonder is there a way to
submit patch series in a single review?
> For example I have 2 patches: A and B. B depends on A. How can I submit
them together?
> 1. The Web interface
(https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface)
seems doesn't allow uploading multiple patches.
> 2. I also tried the command line tool arc
(https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-command-line)
by invoking `arc diff HEAD~` on each commit.
>     But these produce 2 seperate reviews and lose dependency.
>
> Any advice?
>
> Best regards,
> Shaka
> _______________________________________________
> LLVM Developers mailing list
> llvm-dev at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev

Hi Shaka,

I just taught someone else how to do this morning!

What I do first is option 2 to get 2 separate reviews, then navigate to
the web interface for 'B' and click "Edit Related Revisions"
-> "Edit
Parent Revisions" -> <click A>.

This creates a patch "stack" which is what you're after.

I agree it's not very well documented: it took me a while to work out
what to do. Do people think we should add some documentation to this
effect?

Thanks,
Fraser

On Fri, 2021-12-10 at 19:28 +0800, shaka via llvm-dev
wrote:
> Hi all,
> 
> I'm new for community contribution and I wonder is there a way to
> submit patch series in a single review?
> For example I have 2 patches: A and B. B depends on A. How can I
> submit them together?
> 1. The Web interface (
>
https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface
> ) seems doesn't allow uploading multiple patches.
> 2. I also tried the command line tool arc (
>
https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-command-line
> ) by invoking `arc diff HEAD~` on each commit.
>     But these produce 2 seperate reviews and lose dependency.
> 
> Any advice?
> 
> Best regards,
> Shaka
> _______________________________________________
> LLVM Developers mailing list
> llvm-dev at lists.llvm.org
> 
> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
>

I like using the moz-phab tool, which handles this use case pretty well, I
think.
https://moz-conduit.readthedocs.io/en/latest/phabricator-user.html#submitting-patches

Steve

On Fri, Dec 10, 2021 at 3:28 AM shaka via llvm-dev <llvm-dev at
lists.llvm.org>
wrote:
> Hi all,
>
> I'm new for community contribution and I wonder is there a way to
submit
> patch series in a single review?
> For example I have 2 patches: A and B. B depends on A. How can I submit
> them together?
> 1. The Web interface (
>
https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface)
> seems doesn't allow uploading multiple patches.
> 2. I also tried the command line tool arc (
>
https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-command-line)
> by invoking `arc diff HEAD~` on each commit.
>     But these produce 2 seperate reviews and lose dependency.
>
> Any advice?
>
> Best regards,
> Shaka
> _______________________________________________
> LLVM Developers mailing list
> llvm-dev at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20211216/a9556224/attachment.html>