llvm dev - Nov 2021 - Consolidating copies of google/benchmark in the repo (Was: Proposal: introduce dependency on abseil when building benchmarks)

Am Mo., 25. Okt. 2021 um 10:18 Uhr schrieb Mircea Trofin <mtrofin at
google.com>:
> Circling back from https://reviews.llvm.org/D112012 - would having
google/benchmark under a new `llvm-project/third-party` work, instead of
`llvm-project/llvm/utils`? (rationale there, TL;DR; libcxx (and other runtimes)
wants to detach itself from anything `llvm-project/llvm`)
It would be only part of the solution as libcxx also depends on other
things in llvm-project/llvm (CMake modules, lit, ...). If the goal is
to make libcxx etc independent of the /llvm we should find out where
those other dependencies go. Until then, IMHO there is nothing wrong
to have libcxx depend on /llvm/utils/benchmark since it has /llvm is
needed to build libc++ anyway.

Michael

> On Oct 29, 2021, at 7:00 AM, Michael Kruse <llvmdev at meinersbur.de>
wrote:
> 
> Am Mo., 25. Okt. 2021 um 10:18 Uhr schrieb Mircea Trofin <mtrofin at
google.com>:
>> Circling back from https://reviews.llvm.org/D112012 - would having
google/benchmark under a new `llvm-project/third-party` work, instead of
`llvm-project/llvm/utils`? (rationale there, TL;DR; libcxx (and other runtimes)
wants to detach itself from anything `llvm-project/llvm`)
> 
> It would be only part of the solution as libcxx also depends on other
> things in llvm-project/llvm (CMake modules, lit, ...). If the goal is
> to make libcxx etc independent of the /llvm we should find out where
> those other dependencies go. Until then, IMHO there is nothing wrong
> to have libcxx depend on /llvm/utils/benchmark since it has /llvm is
> needed to build libc++ anyway.
I think it would make sense to move third party dependencies out of
llvm-project/llvm for other reasons too, including layering (they can’t depend
on other things in llvm) and license clarity.

-Chris

On Sun, Oct 31, 2021 at 11:57 AM Chris Lattner <clattner at nondot.org>
wrote:
>
>
> > On Oct 29, 2021, at 7:00 AM, Michael Kruse <llvmdev at
meinersbur.de>
> wrote:
> >
> > Am Mo., 25. Okt. 2021 um 10:18 Uhr schrieb Mircea Trofin <
> mtrofin at google.com>:
> >> Circling back from https://reviews.llvm.org/D112012 - would having
> google/benchmark under a new `llvm-project/third-party` work, instead of
> `llvm-project/llvm/utils`? (rationale there, TL;DR; libcxx (and other
> runtimes) wants to detach itself from anything `llvm-project/llvm`)
> >
> > It would be only part of the solution as libcxx also depends on other
> > things in llvm-project/llvm (CMake modules, lit, ...). If the goal is
> > to make libcxx etc independent of the /llvm we should find out where
> > those other dependencies go. Until then, IMHO there is nothing wrong
> > to have libcxx depend on /llvm/utils/benchmark since it has /llvm is
> > needed to build libc++ anyway.
>
> I think it would make sense to move third party dependencies out of
> llvm-project/llvm for other reasons too, including layering (they can’t
> depend on other things in llvm) and license clarity.
sounds good, so I'll create a 'third-party' dir, unless there's
a strong
desire for a different name

>
>
-Chris
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20211101/921348fd/attachment.html>

On Sun, Oct 31, 2021 at 11:57 AM Chris Lattner via llvm-dev <
llvm-dev at lists.llvm.org> wrote:
> I think it would make sense to move third party dependencies out of
> llvm-project/llvm for other reasons too, including layering (they can’t
> depend on other things in llvm) and license clarity.
>
+1, gtest & gmock come to mind.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20211101/aa3b17c1/attachment.html>