Laszlo Ersek
2022-May-04 13:41 UTC
[Libguestfs] [libguestfs PATCH 4/4] tests/regressions: remove "iface"-based restrictions
Now that "iface" is ignored by both backends, the regression tests for RHBZ 690819 and 975797 can be enabled on all arches (regardless of backend). Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1844341 Signed-off-by: Laszlo Ersek <lersek at redhat.com> --- tests/regressions/rhbz690819.sh | 10 +++------- tests/regressions/rhbz975797.sh | 10 +++------- 2 files changed, 6 insertions(+), 14 deletions(-) diff --git a/tests/regressions/rhbz690819.sh b/tests/regressions/rhbz690819.sh index e6f61d00d3ce..9e1bcda845b4 100755 --- a/tests/regressions/rhbz690819.sh +++ b/tests/regressions/rhbz690819.sh @@ -19,18 +19,14 @@ # https://bugzilla.redhat.com/show_bug.cgi?id=690819 # mkfs fails creating a filesytem on a disk device when using a disk # with 'ide' interface +# +# The 'iface' parameter is now ignored: +# https://bugzilla.redhat.com/show_bug.cgi?id=1844341 set -e $TEST_FUNCTIONS skip_if_skipped -# These architectures don't support the 'ide' interface. -skip_if_arch arm -skip_if_arch aarch64 -skip_if_arch ppc64 -skip_if_arch ppc64le -skip_if_arch s390x -skip_if_backend libvirt rm -f rhbz690819.img diff --git a/tests/regressions/rhbz975797.sh b/tests/regressions/rhbz975797.sh index c676abfa3c87..feecf1f2b418 100755 --- a/tests/regressions/rhbz975797.sh +++ b/tests/regressions/rhbz975797.sh @@ -19,18 +19,14 @@ # Regression test for: # https://bugzilla.redhat.com/show_bug.cgi?id=975797 # Ensure the appliance doesn't hang when using the 'iface' parameter. +# +# The 'iface' parameter is now ignored: +# https://bugzilla.redhat.com/show_bug.cgi?id=1844341 set -e $TEST_FUNCTIONS skip_if_skipped -# These architectures don't support the 'ide' interface. -skip_if_arch arm -skip_if_arch aarch64 -skip_if_arch ppc64 -skip_if_arch ppc64le -skip_if_arch s390x -skip_if_backend libvirt rm -f rhbz975797-*.img -- 2.19.1.3.g30247aa5d201
Richard W.M. Jones
2022-May-04 18:50 UTC
[Libguestfs] [libguestfs PATCH 4/4] tests/regressions: remove "iface"-based restrictions
For the whole series: Reviewed-by: Richard W.M. Jones <rjones at redhat.com> Do you think it makes sense to completely drop the two regression tests in patch 4? They're testing something that (probably) cannot go wrong now. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-builder quickly builds VMs from scratch http://libguestfs.org/virt-builder.1.html