Mongrel users - Oct 2007 - Mongrel PID file permissions

Hi !

I''m using Mongrel 1.0.1 with --pid and --user/--group.  The PID files
are correctly owned by the user/group, but their permissions is 0666.
Is that normal ?  Shouldn''t it be something like 0664 ?

Just curious to know if I''m wrong.

Configurator has this (line 77):

    # Writes the PID file but only if we''re on windows.
    def write_pid_file
      if RUBY_PLATFORM !~ /mswin/
        log "Writing PID file to #{@pid_file}"
        open(@pid_file,"w") {|f| f.write(Process.pid) }
      end
    end

The comment''s wrong, and we probably need a File.chmod call there
somewhere.  Should I submit a patch ?

Thanks !
-- 
Fran?ois Beausoleil
http://blog.teksol.info/
http://piston.rubyforge.org/

On 10/5/07, Fran?ois Beausoleil <francois.beausoleil at gmail.com>
wrote:
> Hi !
>
> I''m using Mongrel 1.0.1 with --pid and --user/--group.  The PID
files
> are correctly owned by the user/group, but their permissions is 0666.
> Is that normal ?  Shouldn''t it be something like 0664 ?
>
> Just curious to know if I''m wrong.
>
> Configurator has this (line 77):
>
>    # Writes the PID file but only if we''re on windows.
>    def write_pid_file
>      if RUBY_PLATFORM !~ /mswin/
>        log "Writing PID file to #{@pid_file}"
>        open(@pid_file,"w") {|f| f.write(Process.pid) }
>      end
>    end
>
> The comment''s wrong, and we probably need a File.chmod call there
> somewhere.  Should I submit a patch ?
>
Yes please!

I don''t see any reference to the file permission for the file, so
maybe you require File.chmod after writting to it.

Post it to RubyForge tracker (under patches) and someone will check
and test it before commiting.

Again, thank you for your time.

-- 
Luis Lavena
Multimedia systems
-
Leaders are made, they are not born. They are made by hard effort,
which is the price which all of us must pay to achieve any goal that
is worthwhile.
Vince Lombardi

Hi !

2007/10/5, Luis Lavena <luislavena at gmail.com>:
> I don''t see any reference to the file permission for the file, so
> maybe you require File.chmod after writting to it.
>
> Post it to RubyForge tracker (under patches) and someone will check
> and test it before commiting.
Take the patch from here:

http://rubyforge.org/tracker/index.php?func=detail&aid=14641&group_id=1306&atid=5147

Bye !
Fran?ois